From: Tony Lindgren <tony@atomide.com>
To: "Govindraj.R" <govindraj.raja@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Felipe Balbi <balbi@ti.com>, Kevin Hilman <khilman@ti.com>,
Russ Dill <russ.dill@gmail.com>, Paul Walmsley <paul@pwsan.com>,
Ameya Palande <ameya.palande@ti.com>
Subject: Re: [PATCH v3] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup
Date: Tue, 5 Jun 2012 04:28:34 -0700 [thread overview]
Message-ID: <20120605112834.GO12766@atomide.com> (raw)
In-Reply-To: <1336729242-16168-1-git-send-email-govindraj.raja@ti.com>
* Govindraj.R <govindraj.raja@ti.com> [120511 02:45]:
> From: "Govindraj.R" <govindraj.raja@ti.com>
> --- a/arch/arm/mach-omap2/serial.c
> +++ b/arch/arm/mach-omap2/serial.c
> #else
> -static void omap_serial_fill_default_pads(struct omap_board_data *bdata) {}
> +static void __init omap_serial_check_wakeup(struct omap_board_data *bdata
> + struct omap_uart_state *uart) {}
> #endif
There's a comma missing here that breaks CONFIG_OMAP_MUX is not set here ^^^.
I've updated the patch to add it.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup
Date: Tue, 5 Jun 2012 04:28:34 -0700 [thread overview]
Message-ID: <20120605112834.GO12766@atomide.com> (raw)
In-Reply-To: <1336729242-16168-1-git-send-email-govindraj.raja@ti.com>
* Govindraj.R <govindraj.raja@ti.com> [120511 02:45]:
> From: "Govindraj.R" <govindraj.raja@ti.com>
> --- a/arch/arm/mach-omap2/serial.c
> +++ b/arch/arm/mach-omap2/serial.c
> #else
> -static void omap_serial_fill_default_pads(struct omap_board_data *bdata) {}
> +static void __init omap_serial_check_wakeup(struct omap_board_data *bdata
> + struct omap_uart_state *uart) {}
> #endif
There's a comma missing here that breaks CONFIG_OMAP_MUX is not set here ^^^.
I've updated the patch to add it.
Tony
next prev parent reply other threads:[~2012-06-05 11:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 13:05 [PATCH v2] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup Govindraj.R
2012-05-10 13:05 ` Govindraj.R
2012-05-10 19:11 ` Tony Lindgren
2012-05-10 19:11 ` Tony Lindgren
2012-05-11 9:13 ` Raja, Govindraj
2012-05-11 9:13 ` Raja, Govindraj
2012-05-11 8:34 ` Russ Dill
2012-05-11 8:34 ` Russ Dill
2012-05-11 9:15 ` Raja, Govindraj
2012-05-11 9:15 ` Raja, Govindraj
2012-05-11 9:40 ` [PATCH v3] " Govindraj.R
2012-05-11 9:40 ` Govindraj.R
2012-05-23 23:11 ` Kevin Hilman
2012-05-23 23:11 ` Kevin Hilman
2012-06-05 11:08 ` Tony Lindgren
2012-06-05 11:08 ` Tony Lindgren
2012-06-05 11:28 ` Tony Lindgren [this message]
2012-06-05 11:28 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605112834.GO12766@atomide.com \
--to=tony@atomide.com \
--cc=ameya.palande@ti.com \
--cc=balbi@ti.com \
--cc=govindraj.raja@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=russ.dill@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.