From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Liam Girdwood <lrg@ti.com>
Subject: Re: dapm_widget_power_read_file() symmetry issue?
Date: Tue, 5 Jun 2012 17:46:04 +0100 [thread overview]
Message-ID: <20120605164603.GB14958@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FCD393D.3040205@wwwdotorg.org>
[-- Attachment #1.1: Type: text/plain, Size: 333 bytes --]
On Mon, Jun 04, 2012 at 04:39:57PM -0600, Stephen Warren wrote:
> > list_for_each_entry(p, &w->sinks, list_source) {
> > if (p->connected && !p->connected(w, p->sink))
> > continue;
> Should that last call to p->connected() be p->connected(p->source, w),
> since the function's parameters are (source, sink)?
Probably, yes.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2012-06-05 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 22:39 dapm_widget_power_read_file() symmetry issue? Stephen Warren
2012-06-05 16:46 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605164603.GB14958@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.