* dapm_widget_power_read_file() symmetry issue?
@ 2012-06-04 22:39 Stephen Warren
2012-06-05 16:46 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Warren @ 2012-06-04 22:39 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel@alsa-project.org
In dapm_widget_power_read_file(), there is first:
> list_for_each_entry(p, &w->sources, list_sink) {
> if (p->connected && !p->connected(w, p->sink))
> continue;
then right after that:
> list_for_each_entry(p, &w->sinks, list_source) {
> if (p->connected && !p->connected(w, p->sink))
> continue;
Should that last call to p->connected() be p->connected(p->source, w),
since the function's parameters are (source, sink)?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: dapm_widget_power_read_file() symmetry issue?
2012-06-04 22:39 dapm_widget_power_read_file() symmetry issue? Stephen Warren
@ 2012-06-05 16:46 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-06-05 16:46 UTC (permalink / raw)
To: Stephen Warren; +Cc: alsa-devel@alsa-project.org, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 333 bytes --]
On Mon, Jun 04, 2012 at 04:39:57PM -0600, Stephen Warren wrote:
> > list_for_each_entry(p, &w->sinks, list_source) {
> > if (p->connected && !p->connected(w, p->sink))
> > continue;
> Should that last call to p->connected() be p->connected(p->source, w),
> since the function's parameters are (source, sink)?
Probably, yes.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-05 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-04 22:39 dapm_widget_power_read_file() symmetry issue? Stephen Warren
2012-06-05 16:46 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.