From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
oleg@redhat.com, Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>, Ingo Molnar <mingo@elte.hu>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] uprobes: Pass probed vaddr to arch_uprobe_analyze_insn()
Date: Wed, 6 Jun 2012 17:14:23 +0530 [thread overview]
Message-ID: <20120606114423.GA32094@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120606094014.GD9495@gmail.com>
* Ingo Molnar <mingo@kernel.org> [2012-06-06 11:40:15]:
>
> * Ananth N Mavinakayanahalli <ananth@in.ibm.com> wrote:
>
> > On Wed, Jun 06, 2012 at 11:23:52AM +0200, Peter Zijlstra wrote:
> > > On Wed, 2012-06-06 at 14:49 +0530, Ananth N Mavinakayanahalli wrote:
> > > > +int arch_uprobe_analyze_insn(struct arch_uprobe *auprobe, struct mm_struct *mm, loff_t vaddr)
> > >
> > > Don't we traditionally use unsigned long to pass vaddrs?
> >
> > Right. But the vaddr we pass here is vma_info->vaddr which is loff_t.
> > I guess I should've made that clear in the patch description.
>
> Why not fix struct vma_info's vaddr type?
>
Calculating and comparing vaddr results either uses variables of type loff_t.
To avoid typecasting and avoid overflow at each of these places, we used
loff_t.
Ananth, install_breakpoint() already has a variable of type addr of type
unsigned long. Why dont you use addr instead of vaddr.
--
Thanks and regards
Srikar
WARNING: multiple messages have this Message-ID (diff)
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
linuxppc-dev@lists.ozlabs.org,
lkml <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
benh@kernel.crashing.org, Anton Blanchard <anton@samba.org>,
Ingo Molnar <mingo@elte.hu>,
oleg@redhat.com
Subject: Re: [PATCH 1/2] uprobes: Pass probed vaddr to arch_uprobe_analyze_insn()
Date: Wed, 6 Jun 2012 17:14:23 +0530 [thread overview]
Message-ID: <20120606114423.GA32094@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120606094014.GD9495@gmail.com>
* Ingo Molnar <mingo@kernel.org> [2012-06-06 11:40:15]:
>
> * Ananth N Mavinakayanahalli <ananth@in.ibm.com> wrote:
>
> > On Wed, Jun 06, 2012 at 11:23:52AM +0200, Peter Zijlstra wrote:
> > > On Wed, 2012-06-06 at 14:49 +0530, Ananth N Mavinakayanahalli wrote:
> > > > +int arch_uprobe_analyze_insn(struct arch_uprobe *auprobe, struct mm_struct *mm, loff_t vaddr)
> > >
> > > Don't we traditionally use unsigned long to pass vaddrs?
> >
> > Right. But the vaddr we pass here is vma_info->vaddr which is loff_t.
> > I guess I should've made that clear in the patch description.
>
> Why not fix struct vma_info's vaddr type?
>
Calculating and comparing vaddr results either uses variables of type loff_t.
To avoid typecasting and avoid overflow at each of these places, we used
loff_t.
Ananth, install_breakpoint() already has a variable of type addr of type
unsigned long. Why dont you use addr instead of vaddr.
--
Thanks and regards
Srikar
next prev parent reply other threads:[~2012-06-06 11:47 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 9:19 [PATCH 1/2] uprobes: Pass probed vaddr to arch_uprobe_analyze_insn() Ananth N Mavinakayanahalli
2012-06-06 9:19 ` Ananth N Mavinakayanahalli
2012-06-06 9:21 ` [PATCH 2/2] [POWERPC] uprobes: powerpc port Ananth N Mavinakayanahalli
2012-06-06 9:21 ` Ananth N Mavinakayanahalli
2012-06-06 9:27 ` Peter Zijlstra
2012-06-06 9:27 ` Peter Zijlstra
2012-06-06 9:35 ` Ananth N Mavinakayanahalli
2012-06-06 9:35 ` Ananth N Mavinakayanahalli
2012-06-06 18:08 ` Jim Keniston
2012-06-06 18:08 ` Jim Keniston
2012-06-08 4:36 ` Ananth N Mavinakayanahalli
2012-06-08 4:36 ` Ananth N Mavinakayanahalli
2012-06-08 5:51 ` Michael Ellerman
2012-06-08 5:51 ` Michael Ellerman
2012-06-08 6:01 ` Ananth N Mavinakayanahalli
2012-06-08 6:01 ` Ananth N Mavinakayanahalli
2012-06-08 6:17 ` Michael Ellerman
2012-06-08 6:17 ` Michael Ellerman
2012-06-08 6:19 ` Ananth N Mavinakayanahalli
2012-06-08 6:19 ` Ananth N Mavinakayanahalli
2012-06-08 6:38 ` Michael Ellerman
2012-06-08 6:38 ` Michael Ellerman
2012-06-08 9:21 ` Ananth N Mavinakayanahalli
2012-06-08 9:21 ` Ananth N Mavinakayanahalli
2012-06-12 4:01 ` Michael Ellerman
2012-06-12 4:01 ` Michael Ellerman
2012-06-12 4:52 ` Ananth N Mavinakayanahalli
2012-06-12 4:52 ` Ananth N Mavinakayanahalli
2012-06-06 9:23 ` [PATCH 1/2] uprobes: Pass probed vaddr to arch_uprobe_analyze_insn() Peter Zijlstra
2012-06-06 9:23 ` Peter Zijlstra
2012-06-06 9:37 ` Ananth N Mavinakayanahalli
2012-06-06 9:37 ` Ananth N Mavinakayanahalli
2012-06-06 9:40 ` Ingo Molnar
2012-06-06 9:40 ` Ingo Molnar
2012-06-06 10:22 ` Ananth N Mavinakayanahalli
2012-06-06 10:22 ` Ananth N Mavinakayanahalli
2012-06-06 11:44 ` Srikar Dronamraju [this message]
2012-06-06 11:44 ` Srikar Dronamraju
2012-06-08 4:33 ` Ananth N Mavinakayanahalli
2012-06-08 4:33 ` Ananth N Mavinakayanahalli
2012-06-06 15:08 ` Oleg Nesterov
2012-06-06 15:08 ` Oleg Nesterov
2012-06-06 16:30 ` Srikar Dronamraju
2012-06-06 16:30 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120606114423.GA32094@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.