All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Richard Yao <ryao@gentoo.org>,
	stable@vger.kernel.org, linux-scsi@vger.kernel.org,
	James Smart <james.smart@emulex.com>
Subject: Re: scsi: lpfc_scsi: Remove unused variables
Date: Thu, 7 Jun 2012 15:37:51 +0900	[thread overview]
Message-ID: <20120607063751.GB16645@kroah.com> (raw)
In-Reply-To: <20120607061255.GB3210@burratino>

On Thu, Jun 07, 2012 at 01:12:56AM -0500, Jonathan Nieder wrote:
> Hi Richard,
> 
> Richard Yao wrote:
> 
> > This is my first time patch submission. The commit message should
> > explain the issue.
> >
> > commit ba8c7a7a629b736fdc1abceaa3ec49f8820aec08
> > Author: Richard Yao <ryao@cs.stonybrook.edu>
> > Date:   Thu Jun 7 01:44:31 2012 -0400
> >
> >     scsi: lpfc_scsi: Remove unused variables
> >
> >     Kernels built with CONFIG_SCSI_LPFC fail to compile due to the use of
> >     -Werror=unused-variable. We solve that by removing some unused
> >     variables.
> 
> Wouldn't a saner fix be to stop using -Werror=unused-variable, or am I
> missing something subtle?

Yes, that is correct, older versions of gcc, and sometimes newer ones,
get this logic wrong and incorrectly flag variables that really are used
due to bugs in their detection logic.  Don't require a developer to have
a gcc version that is different from what the rest of the kernel
requires, as that is not allowed.

thanks,

greg k-h

      parent reply	other threads:[~2012-06-07  6:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4FD0434B.7090405@gentoo.org>
2012-06-07  6:12 ` scsi: lpfc_scsi: Remove unused variables Jonathan Nieder
2012-06-07  6:21   ` Richard Yao
2012-06-07  6:42     ` Jonathan Nieder
2012-06-11 14:02       ` James Smart
2012-06-07  6:37   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120607063751.GB16645@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=james.smart@emulex.com \
    --cc=jrnieder@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ryao@gentoo.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.