From: James Smart <james.smart@emulex.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Richard Yao <ryao@gentoo.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: scsi: lpfc_scsi: Remove unused variables
Date: Mon, 11 Jun 2012 10:02:34 -0400 [thread overview]
Message-ID: <4FD5FA7A.5080906@emulex.com> (raw)
In-Reply-To: <20120607064224.GD3210@burratino>
Richard,
fyi - this error in lpfc was corrected in our 8.3.31 patch set - posted
back in May:
http://www.spinics.net/lists/linux-scsi/msg59216.html
-- james
On 6/7/2012 2:42 AM, Jonathan Nieder wrote:
> Richard Yao wrote:
>
>> Using -Werror enables us to catch potential runtime issues before they
>> happen.
> You have more trust in GCC and other compilers than I do.
>
> If you'd like some entertainment, then for example see:
>
> http://gcc.gnu.org/PR52798
> http://gcc.gnu.org/PR25509
>
> Bugs and misdesigned features do not have to be involved for this to
> be a problem --- all it takes is a gcc upgrade that adds a new
> warning, and suddenly you've turned your existing potential code
> cleanliness improvements into failed builds and lots of wasted time
> for innocent sysadmins. -Werror is great for development, but using
> it in production turns out to be pretty much always a terrible idea.
>
> Thanks for the chance to vent about this. :) It's bad, bad, bad.
>
> Ciao,
> Jonathan
>
next prev parent reply other threads:[~2012-06-11 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4FD0434B.7090405@gentoo.org>
2012-06-07 6:12 ` scsi: lpfc_scsi: Remove unused variables Jonathan Nieder
2012-06-07 6:21 ` Richard Yao
2012-06-07 6:42 ` Jonathan Nieder
2012-06-11 14:02 ` James Smart [this message]
2012-06-07 6:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD5FA7A.5080906@emulex.com \
--to=james.smart@emulex.com \
--cc=jrnieder@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ryao@gentoo.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.