From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: dan.magenheimer@oracle.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/11] mm: frontswap: remove unnecessary check during initialization
Date: Thu, 7 Jun 2012 14:31:45 -0400 [thread overview]
Message-ID: <20120607183145.GB9472@phenom.dumpdata.com> (raw)
In-Reply-To: <1338980115-2394-7-git-send-email-levinsasha928@gmail.com>
On Wed, Jun 06, 2012 at 12:55:11PM +0200, Sasha Levin wrote:
Could you explain in the git commit why it is unnecessary?
I am pretty sure I know - it is b/c frontswap_init already
does the check, but the git commit should mention it.
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
> mm/frontswap.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/mm/frontswap.c b/mm/frontswap.c
> index f2f4685..bf99c7d 100644
> --- a/mm/frontswap.c
> +++ b/mm/frontswap.c
> @@ -89,8 +89,7 @@ void __frontswap_init(unsigned type)
> BUG_ON(sis == NULL);
> if (sis->frontswap_map == NULL)
> return;
> - if (frontswap_enabled)
> - frontswap_ops.init(type);
> + frontswap_ops.init(type);
> }
> EXPORT_SYMBOL(__frontswap_init);
>
> --
> 1.7.8.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: dan.magenheimer@oracle.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/11] mm: frontswap: remove unnecessary check during initialization
Date: Thu, 7 Jun 2012 14:31:45 -0400 [thread overview]
Message-ID: <20120607183145.GB9472@phenom.dumpdata.com> (raw)
In-Reply-To: <1338980115-2394-7-git-send-email-levinsasha928@gmail.com>
On Wed, Jun 06, 2012 at 12:55:11PM +0200, Sasha Levin wrote:
Could you explain in the git commit why it is unnecessary?
I am pretty sure I know - it is b/c frontswap_init already
does the check, but the git commit should mention it.
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
> mm/frontswap.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/mm/frontswap.c b/mm/frontswap.c
> index f2f4685..bf99c7d 100644
> --- a/mm/frontswap.c
> +++ b/mm/frontswap.c
> @@ -89,8 +89,7 @@ void __frontswap_init(unsigned type)
> BUG_ON(sis == NULL);
> if (sis->frontswap_map == NULL)
> return;
> - if (frontswap_enabled)
> - frontswap_ops.init(type);
> + frontswap_ops.init(type);
> }
> EXPORT_SYMBOL(__frontswap_init);
>
> --
> 1.7.8.6
next prev parent reply other threads:[~2012-06-07 18:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 10:55 [PATCH 01/11] mm: frontswap: remove casting from function calls through ops structure Sasha Levin
2012-06-06 10:55 ` Sasha Levin
2012-06-06 10:55 ` [PATCH 02/11] mm: frontswap: trivial coding convention issues Sasha Levin
2012-06-06 10:55 ` Sasha Levin
2012-06-06 10:55 ` [PATCH 03/11] mm: frontswap: split out __frontswap_curr_pages Sasha Levin
2012-06-06 10:55 ` Sasha Levin
2012-06-06 10:55 ` [PATCH 04/11] mm: frontswap: split out __frontswap_unuse_pages Sasha Levin
2012-06-06 10:55 ` Sasha Levin
2012-06-06 10:55 ` [PATCH 05/11] mm: frontswap: split frontswap_shrink further to eliminate locking games Sasha Levin
2012-06-06 10:55 ` Sasha Levin
2012-06-06 11:30 ` Konrad Rzeszutek Wilk
2012-06-06 11:37 ` Sasha Levin
2012-06-06 11:37 ` Sasha Levin
2012-06-07 18:28 ` Konrad Rzeszutek Wilk
2012-06-07 18:28 ` Konrad Rzeszutek Wilk
2012-06-06 10:55 ` [PATCH 06/11] mm: frontswap: make all branches of if statement in put page consistent Sasha Levin
2012-06-06 10:55 ` Sasha Levin
2012-06-07 18:30 ` Konrad Rzeszutek Wilk
2012-06-07 18:30 ` Konrad Rzeszutek Wilk
2012-06-07 20:56 ` Dan Magenheimer
2012-06-07 20:56 ` Dan Magenheimer
2012-06-06 10:55 ` [PATCH 07/11] mm: frontswap: remove unnecessary check during initialization Sasha Levin
2012-06-06 10:55 ` Sasha Levin
2012-06-07 18:31 ` Konrad Rzeszutek Wilk [this message]
2012-06-07 18:31 ` Konrad Rzeszutek Wilk
2012-06-06 10:55 ` [PATCH 08/11] mm: frontswap: add tracing support Sasha Levin
2012-06-06 10:55 ` Sasha Levin
2012-06-07 18:40 ` Konrad Rzeszutek Wilk
2012-06-07 18:40 ` Konrad Rzeszutek Wilk
2012-06-06 10:55 ` [PATCH 09/11] mm: frontswap: remove unused variable in init Sasha Levin
2012-06-06 10:55 ` Sasha Levin
2012-06-06 10:55 ` [PATCH 10/11] mm: frontswap: split out function to clear a page out Sasha Levin
2012-06-06 10:55 ` Sasha Levin
2012-06-06 10:55 ` [PATCH 11/11] mm: frontswap: remove unneeded headers Sasha Levin
2012-06-06 10:55 ` Sasha Levin
2012-06-07 18:42 ` [PATCH 01/11] mm: frontswap: remove casting from function calls through ops structure Konrad Rzeszutek Wilk
2012-06-07 18:42 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607183145.GB9472@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.