All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: a whole bunch of crashes since todays -mm merge.
Date: Thu, 7 Jun 2012 21:00:08 -0400	[thread overview]
Message-ID: <20120608010008.GA7191@redhat.com> (raw)
In-Reply-To: <CA+55aFzivM8Z1Bjk3Qo2vtnQhCQ7fQ4rf_a+EXY7noXQcxL_CA@mail.gmail.com>

On Thu, Jun 07, 2012 at 05:52:52PM -0700, Linus Torvalds wrote:
 > On Thu, Jun 7, 2012 at 5:24 PM, Dave Jones <davej@redhat.com> wrote:
 > > I just started seeing crashes while doing simple things, like logging on a console..
 > 
 > I'm looking at it right now, and the sync_mm_rss() patch is pure
 > garbage. In many ways.
 > 
 > You can't do sync_mm_rss() from mmdrop(), because there's no reason to
 > believe that the task that does mmdrop() does it on its own active_mm.
 > And even if you *could* do it there, it's still horribly wrong,
 > because it does it at the end *after* it already freed the mm!
 > 
 > Does it go away if you revert that (commit 40af1bbdca47). I wish I
 > hadn't merged it, or that I had noticed how horrible it was before I
 > pushed out.

Hmm, I did a rebuild with a r8169 debug patch Francois sent me backed out,
and now it looks like it's fine again.

Or I might just be getting lucky..

	Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Dave Jones <davej@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: a whole bunch of crashes since todays -mm merge.
Date: Thu, 7 Jun 2012 21:00:08 -0400	[thread overview]
Message-ID: <20120608010008.GA7191@redhat.com> (raw)
In-Reply-To: <CA+55aFzivM8Z1Bjk3Qo2vtnQhCQ7fQ4rf_a+EXY7noXQcxL_CA@mail.gmail.com>

On Thu, Jun 07, 2012 at 05:52:52PM -0700, Linus Torvalds wrote:
 > On Thu, Jun 7, 2012 at 5:24 PM, Dave Jones <davej@redhat.com> wrote:
 > > I just started seeing crashes while doing simple things, like logging on a console..
 > 
 > I'm looking at it right now, and the sync_mm_rss() patch is pure
 > garbage. In many ways.
 > 
 > You can't do sync_mm_rss() from mmdrop(), because there's no reason to
 > believe that the task that does mmdrop() does it on its own active_mm.
 > And even if you *could* do it there, it's still horribly wrong,
 > because it does it at the end *after* it already freed the mm!
 > 
 > Does it go away if you revert that (commit 40af1bbdca47). I wish I
 > hadn't merged it, or that I had noticed how horrible it was before I
 > pushed out.

Hmm, I did a rebuild with a r8169 debug patch Francois sent me backed out,
and now it looks like it's fine again.

Or I might just be getting lucky..

	Dave


  reply	other threads:[~2012-06-08  1:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08  0:24 a whole bunch of crashes since todays -mm merge Dave Jones
2012-06-08  0:24 ` Dave Jones
2012-06-08  0:52 ` Linus Torvalds
2012-06-08  0:52   ` Linus Torvalds
2012-06-08  1:00   ` Dave Jones [this message]
2012-06-08  1:00     ` Dave Jones
2012-06-08  1:06     ` Linus Torvalds
2012-06-08  1:06       ` Linus Torvalds
2012-06-08  1:12       ` Dave Jones
2012-06-08  1:12         ` Dave Jones
2012-06-08  1:25         ` Linus Torvalds
2012-06-08  1:25           ` Linus Torvalds
2012-06-08  1:05   ` Andrew Morton
2012-06-08  1:05     ` Andrew Morton
2012-06-08  1:09     ` Linus Torvalds
2012-06-08  1:09       ` Linus Torvalds
2012-06-08  2:22       ` Dave Jones
2012-06-08  2:22         ` Dave Jones
2012-06-08  1:39     ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120608010008.GA7191@redhat.com \
    --to=davej@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.