From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tyler Hicks <tyhicks@canonical.com>
Cc: Dustin Kirkland <dustin.kirkland@gazzang.com>,
ecryptfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] eCryptfs: fix ecryptfs_privileged_open() for read only files
Date: Sat, 9 Jun 2012 12:11:29 +0300 [thread overview]
Message-ID: <20120609091129.GD877@elgon.mountain> (raw)
The intent here is to handle read only opens differently. For example,
if we don't want to create the file if it doesn't exist. The problem
here is that O_RDONLY is 0 and if (x & 0) {... is always false.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This is a static checker bug, and I am not very familiar with eCryptfs.
Please review carefully.
diff --git a/fs/ecryptfs/kthread.c b/fs/ecryptfs/kthread.c
index 69f994a..d01b364 100644
--- a/fs/ecryptfs/kthread.c
+++ b/fs/ecryptfs/kthread.c
@@ -149,7 +149,7 @@ int ecryptfs_privileged_open(struct file **lower_file,
(*lower_file) = dentry_open(lower_dentry, lower_mnt, flags, cred);
if (!IS_ERR(*lower_file))
goto out;
- if (flags & O_RDONLY) {
+ if (!(flags & O_RDWR)) {
rc = PTR_ERR((*lower_file));
goto out;
}
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [patch] eCryptfs: fix ecryptfs_privileged_open() for read only files
Date: Sat, 09 Jun 2012 09:11:29 +0000 [thread overview]
Message-ID: <20120609091129.GD877@elgon.mountain> (raw)
The intent here is to handle read only opens differently. For example,
if we don't want to create the file if it doesn't exist. The problem
here is that O_RDONLY is 0 and if (x & 0) {... is always false.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This is a static checker bug, and I am not very familiar with eCryptfs.
Please review carefully.
diff --git a/fs/ecryptfs/kthread.c b/fs/ecryptfs/kthread.c
index 69f994a..d01b364 100644
--- a/fs/ecryptfs/kthread.c
+++ b/fs/ecryptfs/kthread.c
@@ -149,7 +149,7 @@ int ecryptfs_privileged_open(struct file **lower_file,
(*lower_file) = dentry_open(lower_dentry, lower_mnt, flags, cred);
if (!IS_ERR(*lower_file))
goto out;
- if (flags & O_RDONLY) {
+ if (!(flags & O_RDWR)) {
rc = PTR_ERR((*lower_file));
goto out;
}
next reply other threads:[~2012-06-09 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 9:11 Dan Carpenter [this message]
2012-06-09 9:11 ` [patch] eCryptfs: fix ecryptfs_privileged_open() for read only files Dan Carpenter
2012-06-12 19:02 ` Tyler Hicks
2012-06-12 19:02 ` Tyler Hicks
2012-06-12 19:17 ` Dan Carpenter
2012-06-12 19:17 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120609091129.GD877@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=dustin.kirkland@gazzang.com \
--cc=ecryptfs@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=tyhicks@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.