diff for duplicates of <20120609190702.GE13539@mwanda> diff --git a/a/1.txt b/N1/1.txt index 440cd49..45ef627 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ On Sat, Jun 09, 2012 at 08:12:56PM +0200, Johannes Berg wrote: > On Sat, 2012-06-09 at 18:57 +0300, Dan Carpenter wrote: > > CMD_SYNC is zero so the if (cmd->flags & CMD_SYNC) is never true. I -> > think it should be if (cmd->flags = CMD_SYNC). This enables a lockdep +> > think it should be if (cmd->flags == CMD_SYNC). This enables a lockdep > > assertion. > > Good catch, thanks. It should really be if (!(cmd->flags & CMD_ASYNC)) diff --git a/a/content_digest b/N1/content_digest index 654d71f..3e4566e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01339265576.5029.1.camel@jlt3.sipsolutions.net\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [patch] iwlwifi: turn on a lockdep assertion\0" - "Date\0Sat, 09 Jun 2012 19:07:02 +0000\0" + "Date\0Sat, 9 Jun 2012 22:07:02 +0300\0" "To\0Johannes Berg <johannes@sipsolutions.net>\0" "Cc\0Wey-Yi Guy <wey-yi.w.guy@intel.com>" Intel Linux Wireless <ilw@linux.intel.com> @@ -14,7 +14,7 @@ "On Sat, Jun 09, 2012 at 08:12:56PM +0200, Johannes Berg wrote:\n" "> On Sat, 2012-06-09 at 18:57 +0300, Dan Carpenter wrote:\n" "> > CMD_SYNC is zero so the if (cmd->flags & CMD_SYNC) is never true. I\n" - "> > think it should be if (cmd->flags = CMD_SYNC). This enables a lockdep\n" + "> > think it should be if (cmd->flags == CMD_SYNC). This enables a lockdep\n" "> > assertion.\n" "> \n" "> Good catch, thanks. It should really be if (!(cmd->flags & CMD_ASYNC))\n" @@ -30,4 +30,4 @@ "regards,\n" dan carpenter -aa6b322a2cd97965573cce6d593cd0d2b1bca5bc9ae6b58db583c67c8d316aa5 +34fc751c41d877d5454790006b15b7ac080f6cfd9000219582e169fa240c3cd8
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.