From: Dan Carpenter <dan.carpenter@oracle.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] iwlwifi: turn on a lockdep assertion
Date: Sat, 09 Jun 2012 19:07:02 +0000 [thread overview]
Message-ID: <20120609190702.GE13539@mwanda> (raw)
In-Reply-To: <1339265576.5029.1.camel@jlt3.sipsolutions.net>
On Sat, Jun 09, 2012 at 08:12:56PM +0200, Johannes Berg wrote:
> On Sat, 2012-06-09 at 18:57 +0300, Dan Carpenter wrote:
> > CMD_SYNC is zero so the if (cmd->flags & CMD_SYNC) is never true. I
> > think it should be if (cmd->flags = CMD_SYNC). This enables a lockdep
> > assertion.
>
> Good catch, thanks. It should really be if (!(cmd->flags & CMD_ASYNC))
> though I think as there could be other flags set which don't make it
> non-sync.
>
> I'll commit a fix on Monday unless you want to send a separate patch
> (which I'll then pick up on Monday :-) )
Sure. I'll resend it.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] iwlwifi: turn on a lockdep assertion
Date: Sat, 9 Jun 2012 22:07:02 +0300 [thread overview]
Message-ID: <20120609190702.GE13539@mwanda> (raw)
In-Reply-To: <1339265576.5029.1.camel@jlt3.sipsolutions.net>
On Sat, Jun 09, 2012 at 08:12:56PM +0200, Johannes Berg wrote:
> On Sat, 2012-06-09 at 18:57 +0300, Dan Carpenter wrote:
> > CMD_SYNC is zero so the if (cmd->flags & CMD_SYNC) is never true. I
> > think it should be if (cmd->flags == CMD_SYNC). This enables a lockdep
> > assertion.
>
> Good catch, thanks. It should really be if (!(cmd->flags & CMD_ASYNC))
> though I think as there could be other flags set which don't make it
> non-sync.
>
> I'll commit a fix on Monday unless you want to send a separate patch
> (which I'll then pick up on Monday :-) )
Sure. I'll resend it.
regards,
dan carpenter
next prev parent reply other threads:[~2012-06-09 19:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 15:57 [patch] iwlwifi: turn on a lockdep assertion Dan Carpenter
2012-06-09 15:57 ` Dan Carpenter
2012-06-09 18:12 ` Johannes Berg
2012-06-09 18:12 ` Johannes Berg
2012-06-09 19:07 ` Dan Carpenter [this message]
2012-06-09 19:07 ` Dan Carpenter
2012-06-10 11:25 ` [patch v2] " Dan Carpenter
2012-06-10 11:25 ` Dan Carpenter
2012-06-10 15:25 ` walter harms
2012-06-10 15:25 ` walter harms
2012-06-10 15:39 ` Dan Carpenter
2012-06-10 15:39 ` Dan Carpenter
2012-06-11 6:56 ` Johannes Berg
2012-06-11 6:56 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120609190702.GE13539@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ilw@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.