From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ben Collins <bcollins@bluecherry.net>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch RFC] [media] staging: solo6x10: fix | vs &
Date: Sun, 10 Jun 2012 20:58:04 +0000 [thread overview]
Message-ID: <20120610205804.GG13539@mwanda> (raw)
In-Reply-To: <20120609074732.GA30709@elgon.mountain>
On Sat, Jun 09, 2012 at 10:47:32AM +0300, Dan Carpenter wrote:
> The test here is never true because '&' was used instead of '|'. It was
> the same as:
>
> if (status & ((1<<16) & (1<<17)) ...
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I don't have this hardware and this one really should be tested or
> checked by someone who knows the spec. It could be that the intent was
> to do:
>
> if ((status & SOLO_IIC_STATE_TRNS) &&
> (status & SOLO_IIC_STATE_SIG_ERR) || ...
>
It should be this, yes? For other similar mistakes it was meant to
be this way.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ben Collins <bcollins@bluecherry.net>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch RFC] [media] staging: solo6x10: fix | vs &
Date: Sun, 10 Jun 2012 23:58:04 +0300 [thread overview]
Message-ID: <20120610205804.GG13539@mwanda> (raw)
In-Reply-To: <20120609074732.GA30709@elgon.mountain>
On Sat, Jun 09, 2012 at 10:47:32AM +0300, Dan Carpenter wrote:
> The test here is never true because '&' was used instead of '|'. It was
> the same as:
>
> if (status & ((1<<16) & (1<<17)) ...
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I don't have this hardware and this one really should be tested or
> checked by someone who knows the spec. It could be that the intent was
> to do:
>
> if ((status & SOLO_IIC_STATE_TRNS) &&
> (status & SOLO_IIC_STATE_SIG_ERR) || ...
>
It should be this, yes? For other similar mistakes it was meant to
be this way.
regards,
dan carpenter
next prev parent reply other threads:[~2012-06-10 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 7:47 [patch RFC] [media] staging: solo6x10: fix | vs & Dan Carpenter
2012-06-09 7:47 ` Dan Carpenter
2012-06-10 20:58 ` Dan Carpenter [this message]
2012-06-10 20:58 ` Dan Carpenter
2012-06-15 16:55 ` Ralph Metzler
2012-06-15 16:55 ` Ralph Metzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120610205804.GG13539@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bcollins@bluecherry.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.