From: Paul Mundt <lethal@linux-sh.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] irqdomain: Support for static IRQ mapping and association.
Date: Mon, 11 Jun 2012 03:25:47 +0000 [thread overview]
Message-ID: <20120611032547.GB10170@linux-sh.org> (raw)
In-Reply-To: <20120526015049.1616D3E2336@localhost>
On Fri, May 25, 2012 at 07:50:49PM -0600, Grant Likely wrote:
> On Mon, 21 May 2012 14:06:32 +0900, Paul Mundt <lethal@linux-sh.org> wrote:
> > +int irq_create_strict_mappings(struct irq_domain *domain, unsigned int irq_base,
> > + irq_hw_number_t hwirq_base, int count)
> > +{
> > + int ret;
> > +
> > + ret = irq_alloc_descs(irq_base, irq_base, count,
> > + of_node_to_nid(domain->of_node));
> > + if (unlikely(ret < 0))
> > + return ret;
> > +
> > + ret = irq_domain_associate_many(domain, irq_base, hwirq_base, count);
> > + if (unlikely(ret < 0)) {
> > + irq_free_descs(irq_base, count);
> > + return ret;
> > + }
>
> It would be really good to make sure the hwirqs aren't already
> associated before trying to associate them again. Unfortunately that
> can't be done (nicely) until I get rid of the slow path lookup. I've
> got a patch for that which I'll rebase on top of this one and post soon.
>
Any updates on this? I have quite a few more changes I intend on making,
but there's no point in starting in on that until these existing patches
are sorted out.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] irqdomain: Support for static IRQ mapping and association.
Date: Mon, 11 Jun 2012 12:25:47 +0900 [thread overview]
Message-ID: <20120611032547.GB10170@linux-sh.org> (raw)
In-Reply-To: <20120526015049.1616D3E2336@localhost>
On Fri, May 25, 2012 at 07:50:49PM -0600, Grant Likely wrote:
> On Mon, 21 May 2012 14:06:32 +0900, Paul Mundt <lethal@linux-sh.org> wrote:
> > +int irq_create_strict_mappings(struct irq_domain *domain, unsigned int irq_base,
> > + irq_hw_number_t hwirq_base, int count)
> > +{
> > + int ret;
> > +
> > + ret = irq_alloc_descs(irq_base, irq_base, count,
> > + of_node_to_nid(domain->of_node));
> > + if (unlikely(ret < 0))
> > + return ret;
> > +
> > + ret = irq_domain_associate_many(domain, irq_base, hwirq_base, count);
> > + if (unlikely(ret < 0)) {
> > + irq_free_descs(irq_base, count);
> > + return ret;
> > + }
>
> It would be really good to make sure the hwirqs aren't already
> associated before trying to associate them again. Unfortunately that
> can't be done (nicely) until I get rid of the slow path lookup. I've
> got a patch for that which I'll rebase on top of this one and post soon.
>
Any updates on this? I have quite a few more changes I intend on making,
but there's no point in starting in on that until these existing patches
are sorted out.
next prev parent reply other threads:[~2012-06-11 3:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 5:06 [PATCH 1/2] irqdomain: Simple NUMA awareness Paul Mundt
2012-05-21 5:06 ` Paul Mundt
2012-05-21 5:06 ` [PATCH 2/2] irqdomain: Support for static IRQ mapping and association Paul Mundt
2012-05-21 5:06 ` Paul Mundt
2012-05-26 1:50 ` Grant Likely
2012-05-26 1:50 ` Grant Likely
2012-06-11 3:25 ` Paul Mundt [this message]
2012-06-11 3:25 ` Paul Mundt
2012-06-11 5:02 ` Grant Likely
2012-06-11 5:02 ` Grant Likely
2012-06-13 7:31 ` Paul Mundt
2012-06-13 7:31 ` Paul Mundt
2012-05-26 1:10 ` [PATCH 1/2] irqdomain: Simple NUMA awareness Grant Likely
2012-05-26 1:10 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611032547.GB10170@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.