* [PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word
@ 2012-06-04 19:07 Ricardo Neri
2012-06-04 19:07 ` Ricardo Neri
2012-06-05 10:28 ` Mark Brown
0 siblings, 2 replies; 6+ messages in thread
From: Ricardo Neri @ 2012-06-04 19:07 UTC (permalink / raw)
To: broonie, lrg; +Cc: peter.ujfalusi, Ricardo Neri, alsa-devel, s-guiriec
Hi Mark, Liam,
This patch is to fix an bug that I found in K3.5-rc1. As the IEC-60958 channel
status word is not initialized in hw_params, the params from previous
calls corrupt those of the current playback.
BR
Ricardo
Ricardo Neri (1):
ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word
sound/soc/omap/omap-hdmi.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
--
1.7.5.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word
2012-06-04 19:07 [PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word Ricardo Neri
@ 2012-06-04 19:07 ` Ricardo Neri
2012-06-11 4:41 ` Mark Brown
2012-06-05 10:28 ` Mark Brown
1 sibling, 1 reply; 6+ messages in thread
From: Ricardo Neri @ 2012-06-04 19:07 UTC (permalink / raw)
To: broonie, lrg; +Cc: peter.ujfalusi, Ricardo Neri, alsa-devel, s-guiriec
As the IEC-60958 channel status word is set by ANDing and ORing with
the appropriate definitions, the word bytes need to be initialized
to zero to avoid corruption due to previous hw_params calls.
Signed-off-by: Ricardo Neri <ricardo.neri@ti.com>
---
sound/soc/omap/omap-hdmi.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/omap/omap-hdmi.c b/sound/soc/omap/omap-hdmi.c
index a08245d..24b40bd 100644
--- a/sound/soc/omap/omap-hdmi.c
+++ b/sound/soc/omap/omap-hdmi.c
@@ -108,6 +108,8 @@ static int omap_hdmi_dai_hw_params(struct snd_pcm_substream *substream,
/*
* fill the IEC-60958 channel status word
*/
+ /* initialize the word bytes */
+ memset(iec->status, 0, sizeof(iec->status));
/* specify IEC-60958-3 (commercial use) */
iec->status[0] &= ~IEC958_AES0_PROFESSIONAL;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word
2012-06-04 19:07 [PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word Ricardo Neri
2012-06-04 19:07 ` Ricardo Neri
@ 2012-06-05 10:28 ` Mark Brown
2012-06-05 15:25 ` Ricardo Neri
1 sibling, 1 reply; 6+ messages in thread
From: Mark Brown @ 2012-06-05 10:28 UTC (permalink / raw)
To: Ricardo Neri; +Cc: peter.ujfalusi, alsa-devel, lrg, s-guiriec
[-- Attachment #1.1: Type: text/plain, Size: 392 bytes --]
On Mon, Jun 04, 2012 at 02:07:15PM -0500, Ricardo Neri wrote:
> Hi Mark, Liam,
>
> This patch is to fix an bug that I found in K3.5-rc1. As the IEC-60958 channel
> status word is not initialized in hw_params, the params from previous
> calls corrupt those of the current playback.
Don't send cover letters for single patches, if there's anything useful
to say say it in the patch.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word
2012-06-05 10:28 ` Mark Brown
@ 2012-06-05 15:25 ` Ricardo Neri
2012-06-05 15:27 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Ricardo Neri @ 2012-06-05 15:25 UTC (permalink / raw)
To: Mark Brown; +Cc: peter.ujfalusi, alsa-devel, lrg, s-guiriec
Hi Mark,
On 06/05/2012 05:28 AM, Mark Brown wrote:
> On Mon, Jun 04, 2012 at 02:07:15PM -0500, Ricardo Neri wrote:
>> Hi Mark, Liam,
>>
>> This patch is to fix an bug that I found in K3.5-rc1. As the IEC-60958 channel
>> status word is not initialized in hw_params, the params from previous
>> calls corrupt those of the current playback.
>
> Don't send cover letters for single patches, if there's anything useful
> to say say it in the patch.
Sorry, I will resend as a single patch without the cover letter.
Ricardo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word
2012-06-05 15:25 ` Ricardo Neri
@ 2012-06-05 15:27 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2012-06-05 15:27 UTC (permalink / raw)
To: Ricardo Neri; +Cc: peter.ujfalusi, alsa-devel, lrg, s-guiriec
[-- Attachment #1.1: Type: text/plain, Size: 184 bytes --]
On Tue, Jun 05, 2012 at 10:25:31AM -0500, Ricardo Neri wrote:
> Sorry, I will resend as a single patch without the cover letter.
No need, but please don't do this for future things.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word
2012-06-04 19:07 ` Ricardo Neri
@ 2012-06-11 4:41 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2012-06-11 4:41 UTC (permalink / raw)
To: Ricardo Neri; +Cc: peter.ujfalusi, alsa-devel, lrg, s-guiriec
[-- Attachment #1.1: Type: text/plain, Size: 325 bytes --]
On Mon, Jun 04, 2012 at 02:07:16PM -0500, Ricardo Neri wrote:
> As the IEC-60958 channel status word is set by ANDing and ORing with
> the appropriate definitions, the word bytes need to be initialized
> to zero to avoid corruption due to previous hw_params calls.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-06-11 4:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-04 19:07 [PATCH] ASoC: OMAP: HDMI: Initialize IEC-60958 channel status word Ricardo Neri
2012-06-04 19:07 ` Ricardo Neri
2012-06-11 4:41 ` Mark Brown
2012-06-05 10:28 ` Mark Brown
2012-06-05 15:25 ` Ricardo Neri
2012-06-05 15:27 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.