From: Tony Lindgren <tony@atomide.com>
To: Vaibhav Hiremath <hvaibhav@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP2+: cpu: Add am33xx device under cpu_class_is_omap2
Date: Sun, 10 Jun 2012 23:38:17 -0700 [thread overview]
Message-ID: <20120611063816.GU12766@atomide.com> (raw)
In-Reply-To: <1339253773-24088-1-git-send-email-hvaibhav@ti.com>
* Vaibhav Hiremath <hvaibhav@ti.com> [120609 08:00]:
> Newly added AM33XX device falls under omap2 class, so
> make cpu_class_is_omap2() true for AM33XX
> (Add soc_is_am33xx() check).
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> ---
> arch/arm/plat-omap/include/plat/cpu.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/plat/cpu.h b/arch/arm/plat-omap/include/plat/cpu.h
> index 14f050f..5e36564 100644
> --- a/arch/arm/plat-omap/include/plat/cpu.h
> +++ b/arch/arm/plat-omap/include/plat/cpu.h
> @@ -375,7 +375,7 @@ IS_OMAP_TYPE(3430, 0x3430)
> #define cpu_class_is_omap1() (cpu_is_omap7xx() || cpu_is_omap15xx() || \
> cpu_is_omap16xx())
> #define cpu_class_is_omap2() (cpu_is_omap24xx() || cpu_is_omap34xx() || \
> - cpu_is_omap44xx())
> + cpu_is_omap44xx() || soc_is_am33xx())
>
> /* Various silicon revisions for omap2 */
> #define OMAP242X_CLASS 0x24200024
I think this can be now simply !cpu_class_is_omap1() as there is
a very slim chance that we'll ever be compiling omap1 and omap2+ together
because of the different compiler flags needed.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: cpu: Add am33xx device under cpu_class_is_omap2
Date: Sun, 10 Jun 2012 23:38:17 -0700 [thread overview]
Message-ID: <20120611063816.GU12766@atomide.com> (raw)
In-Reply-To: <1339253773-24088-1-git-send-email-hvaibhav@ti.com>
* Vaibhav Hiremath <hvaibhav@ti.com> [120609 08:00]:
> Newly added AM33XX device falls under omap2 class, so
> make cpu_class_is_omap2() true for AM33XX
> (Add soc_is_am33xx() check).
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> ---
> arch/arm/plat-omap/include/plat/cpu.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/plat/cpu.h b/arch/arm/plat-omap/include/plat/cpu.h
> index 14f050f..5e36564 100644
> --- a/arch/arm/plat-omap/include/plat/cpu.h
> +++ b/arch/arm/plat-omap/include/plat/cpu.h
> @@ -375,7 +375,7 @@ IS_OMAP_TYPE(3430, 0x3430)
> #define cpu_class_is_omap1() (cpu_is_omap7xx() || cpu_is_omap15xx() || \
> cpu_is_omap16xx())
> #define cpu_class_is_omap2() (cpu_is_omap24xx() || cpu_is_omap34xx() || \
> - cpu_is_omap44xx())
> + cpu_is_omap44xx() || soc_is_am33xx())
>
> /* Various silicon revisions for omap2 */
> #define OMAP242X_CLASS 0x24200024
I think this can be now simply !cpu_class_is_omap1() as there is
a very slim chance that we'll ever be compiling omap1 and omap2+ together
because of the different compiler flags needed.
Regards,
Tony
next prev parent reply other threads:[~2012-06-11 6:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 14:56 [PATCH] ARM: OMAP2+: cpu: Add am33xx device under cpu_class_is_omap2 Vaibhav Hiremath
2012-06-09 14:56 ` Vaibhav Hiremath
2012-06-11 6:38 ` Tony Lindgren [this message]
2012-06-11 6:38 ` Tony Lindgren
2012-06-11 6:44 ` Vaibhav Hiremath
2012-06-11 6:44 ` Vaibhav Hiremath
2012-06-11 6:48 ` Tony Lindgren
2012-06-11 6:48 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611063816.GU12766@atomide.com \
--to=tony@atomide.com \
--cc=hvaibhav@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.