All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brown <davidb@codeaurora.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Kukjin Kim" <kgene.kim@samsung.com>,
	"Eric Miao" <eric.y.miao@gmail.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Tomasz Figa" <tomasz.figa@gmail.com>,
	"Paul Gortmaker" <paul.gortmaker@windriver.com>,
	"Paulo Marques" <pmarques@grupopie.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Jon Masters" <jonathan@jonmasters.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: two possible fixes for the KALLSYMS build problem
Date: Tue, 12 Jun 2012 09:02:29 -0700	[thread overview]
Message-ID: <20120612160229.GA21389@codeaurora.org> (raw)
In-Reply-To: <20120612143249.GB7918@n2100.arm.linux.org.uk>

On Tue, Jun 12, 2012 at 03:32:49PM +0100, Russell King - ARM Linux wrote:
> On Mon, Jun 11, 2012 at 01:37:48PM -0700, David Brown wrote:
> > On Fri, Jun 01, 2012 at 09:21:59AM -0700, David Brown wrote:
> > 
> > > David Brown (1):
> > >   ARM: Prevent KALLSYM size mismatch on ARM.
> > > 
> > >  arch/arm/kernel/vmlinux.lds.S |    3 +++
> > >  1 file changed, 3 insertions(+)
> > 
> > Just wondering if anyone has had a chance to look at either of these,
> > or try them.  I haven't seen any KALLSYMS mismatch build errors with
> > either of these patches applied.
> 
> I think variant 2 is the better approach out of either as it doesn't add
> to the size of the resulting kernel image.

The first variant doesn't ever increase the size of the kernel,
either.  Variant two actually makes it a little smaller, since a few
symbols are eliminated.

The second variant is cleaner, though as long as it is safe in every
configuration.

David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

WARNING: multiple messages have this Message-ID (diff)
From: davidb@codeaurora.org (David Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: two possible fixes for the KALLSYMS build problem
Date: Tue, 12 Jun 2012 09:02:29 -0700	[thread overview]
Message-ID: <20120612160229.GA21389@codeaurora.org> (raw)
In-Reply-To: <20120612143249.GB7918@n2100.arm.linux.org.uk>

On Tue, Jun 12, 2012 at 03:32:49PM +0100, Russell King - ARM Linux wrote:
> On Mon, Jun 11, 2012 at 01:37:48PM -0700, David Brown wrote:
> > On Fri, Jun 01, 2012 at 09:21:59AM -0700, David Brown wrote:
> > 
> > > David Brown (1):
> > >   ARM: Prevent KALLSYM size mismatch on ARM.
> > > 
> > >  arch/arm/kernel/vmlinux.lds.S |    3 +++
> > >  1 file changed, 3 insertions(+)
> > 
> > Just wondering if anyone has had a chance to look at either of these,
> > or try them.  I haven't seen any KALLSYMS mismatch build errors with
> > either of these patches applied.
> 
> I think variant 2 is the better approach out of either as it doesn't add
> to the size of the resulting kernel image.

The first variant doesn't ever increase the size of the kernel,
either.  Variant two actually makes it a little smaller, since a few
symbols are eliminated.

The second variant is cleaner, though as long as it is safe in every
configuration.

David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2012-06-12 16:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-01 16:21 [PATCH] ARM: two possible fixes for the KALLSYMS build problem David Brown
2012-06-01 16:21 ` David Brown
2012-06-01 16:22 ` [PATCH variant 1] ARM: Prevent KALLSYM size mismatch on ARM David Brown
2012-06-01 16:22   ` David Brown
2012-06-01 16:22 ` [PATCH variant 2] " David Brown
2012-06-01 16:22   ` David Brown
2012-06-11 20:37 ` [PATCH] ARM: two possible fixes for the KALLSYMS build problem David Brown
2012-06-11 20:37   ` David Brown
2012-06-12 14:32   ` Russell King - ARM Linux
2012-06-12 14:32     ` Russell King - ARM Linux
2012-06-12 16:02     ` David Brown [this message]
2012-06-12 16:02       ` David Brown
2012-06-12 18:20       ` Russell King - ARM Linux
2012-06-12 18:20         ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120612160229.GA21389@codeaurora.org \
    --to=davidb@codeaurora.org \
    --cc=arnd@arndb.de \
    --cc=eric.y.miao@gmail.com \
    --cc=jonathan@jonmasters.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=paul.gortmaker@windriver.com \
    --cc=pmarques@grupopie.com \
    --cc=tomasz.figa@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.