All of lore.kernel.org
 help / color / mirror / Atom feed
From: mturquette@ti.com (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: Check parent for NULL in clk_change_rate
Date: Tue, 12 Jun 2012 15:18:21 -0700	[thread overview]
Message-ID: <20120612221821.GJ19410@gmail.com> (raw)
In-Reply-To: <1339160646-32664-1-git-send-email-pawel.moll@arm.com>

On 20120608-14:04, Pawel Moll wrote:
> clk_change_rate() is accessing parent's rate without checking
> if the parent exists at all. In case of root clocks this will
> cause NULL pointer dereference.
> 
> This patch follows what clk_calc_new_rates() does in such
> situation.
> 
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>

Pawel,

This problem is indeed a real one.  I've taken your patch into clk-next
for testing.

Thanks much,
Mike

WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette@ti.com>
To: Pawel Moll <pawel.moll@arm.com>
Cc: Mike Turquette <mturquette@linaro.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: Check parent for NULL in clk_change_rate
Date: Tue, 12 Jun 2012 15:18:21 -0700	[thread overview]
Message-ID: <20120612221821.GJ19410@gmail.com> (raw)
In-Reply-To: <1339160646-32664-1-git-send-email-pawel.moll@arm.com>

On 20120608-14:04, Pawel Moll wrote:
> clk_change_rate() is accessing parent's rate without checking
> if the parent exists at all. In case of root clocks this will
> cause NULL pointer dereference.
> 
> This patch follows what clk_calc_new_rates() does in such
> situation.
> 
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>

Pawel,

This problem is indeed a real one.  I've taken your patch into clk-next
for testing.

Thanks much,
Mike

  reply	other threads:[~2012-06-12 22:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08 13:04 [PATCH] clk: Check parent for NULL in clk_change_rate Pawel Moll
2012-06-08 13:04 ` Pawel Moll
2012-06-12 22:18 ` Mike Turquette [this message]
2012-06-12 22:18   ` Mike Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120612221821.GJ19410@gmail.com \
    --to=mturquette@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.