From: Tony Lindgren <tony@atomide.com>
To: Afzal Mohammed <afzal@ti.com>
Cc: paul@pwsan.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/9] ARM: OMAP2+: gpmc-tusb6010: Adapt to use gpmc driver
Date: Wed, 13 Jun 2012 05:27:48 -0700 [thread overview]
Message-ID: <20120613122747.GQ12766@atomide.com> (raw)
In-Reply-To: <9c6c6b0298e37b1985a89e2cd99c35504521a1da.1339419379.git.afzal@ti.com>
* Afzal Mohammed <afzal@ti.com> [120611 08:19]:
> @@ -106,7 +123,14 @@ static int tusb_set_async_mode(unsigned sysclk_ps, unsigned fclk_ps)
> tmp = t.cs_wr_off * 1000 + 7000 /* t_acsn_rdy_z */;
> t.wr_cycle = next_clk(t.cs_wr_off, tmp, fclk_ps);
>
> - return gpmc_cs_set_timings(async_cs, &t);
> + /* gpmc driver interface */
> + if (gpmc_tusb_data.pdata != NULL) {
> + gpmc_tusb_cs_data[CS_ASYNC_IDX].time_ctrl.type = has_period;
> + gpmc_tusb_cs_data[CS_ASYNC_IDX].time_ctrl.timings = t;
> + return 0;
> + /* old interface */
> + } else
> + return gpmc_cs_set_timings(async_cs, &t);
> }
>
> static int tusb_set_sync_mode(unsigned sysclk_ps, unsigned fclk_ps)
> @@ -174,7 +198,16 @@ static int tusb_set_sync_mode(unsigned sysclk_ps, unsigned fclk_ps)
> tmp = t.cs_wr_off * 1000 + 7000 /* t_scsn_rdy_z */;
> t.wr_cycle = next_clk(t.cs_wr_off, tmp, fclk_ps);
>
> - return gpmc_cs_set_timings(sync_cs, &t);
> + t.clk_activation = gpmc_ticks_to_ns(1);
> +
> + /* gpmc driver interface */
> + if (gpmc_tusb_data.pdata != NULL) {
> + gpmc_tusb_cs_data[CS_SYNC_IDX].time_ctrl.type = has_period;
> + gpmc_tusb_cs_data[CS_SYNC_IDX].time_ctrl.timings = t;
> + return 0;
> + /* old interface */
> + } else
> + return gpmc_cs_set_timings(sync_cs, &t);
> }
We can drop the old interface for non-mainline cases. In this case
tusb6010 is only used by board-n8x0.c, so it's best to just convert
it all to use the new interface.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/9] ARM: OMAP2+: gpmc-tusb6010: Adapt to use gpmc driver
Date: Wed, 13 Jun 2012 05:27:48 -0700 [thread overview]
Message-ID: <20120613122747.GQ12766@atomide.com> (raw)
In-Reply-To: <9c6c6b0298e37b1985a89e2cd99c35504521a1da.1339419379.git.afzal@ti.com>
* Afzal Mohammed <afzal@ti.com> [120611 08:19]:
> @@ -106,7 +123,14 @@ static int tusb_set_async_mode(unsigned sysclk_ps, unsigned fclk_ps)
> tmp = t.cs_wr_off * 1000 + 7000 /* t_acsn_rdy_z */;
> t.wr_cycle = next_clk(t.cs_wr_off, tmp, fclk_ps);
>
> - return gpmc_cs_set_timings(async_cs, &t);
> + /* gpmc driver interface */
> + if (gpmc_tusb_data.pdata != NULL) {
> + gpmc_tusb_cs_data[CS_ASYNC_IDX].time_ctrl.type = has_period;
> + gpmc_tusb_cs_data[CS_ASYNC_IDX].time_ctrl.timings = t;
> + return 0;
> + /* old interface */
> + } else
> + return gpmc_cs_set_timings(async_cs, &t);
> }
>
> static int tusb_set_sync_mode(unsigned sysclk_ps, unsigned fclk_ps)
> @@ -174,7 +198,16 @@ static int tusb_set_sync_mode(unsigned sysclk_ps, unsigned fclk_ps)
> tmp = t.cs_wr_off * 1000 + 7000 /* t_scsn_rdy_z */;
> t.wr_cycle = next_clk(t.cs_wr_off, tmp, fclk_ps);
>
> - return gpmc_cs_set_timings(sync_cs, &t);
> + t.clk_activation = gpmc_ticks_to_ns(1);
> +
> + /* gpmc driver interface */
> + if (gpmc_tusb_data.pdata != NULL) {
> + gpmc_tusb_cs_data[CS_SYNC_IDX].time_ctrl.type = has_period;
> + gpmc_tusb_cs_data[CS_SYNC_IDX].time_ctrl.timings = t;
> + return 0;
> + /* old interface */
> + } else
> + return gpmc_cs_set_timings(sync_cs, &t);
> }
We can drop the old interface for non-mainline cases. In this case
tusb6010 is only used by board-n8x0.c, so it's best to just convert
it all to use the new interface.
Regards,
Tony
next prev parent reply other threads:[~2012-06-13 12:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 14:58 [PATCH 0/9] Adapt GPMC peripherals, platforms to driver Afzal Mohammed
2012-06-11 14:58 ` Afzal Mohammed
2012-06-11 14:59 ` [PATCH 1/9] ARM: OMAP2+: gpmc-nand: Adapt to use gpmc driver Afzal Mohammed
2012-06-11 14:59 ` Afzal Mohammed
2012-06-11 14:59 ` [PATCH 2/9] ARM: OMAP2+: gpmc-onenand: " Afzal Mohammed
2012-06-11 14:59 ` Afzal Mohammed
2012-06-11 14:59 ` [PATCH 3/9] ARM: OMAP2+: flash: " Afzal Mohammed
2012-06-11 14:59 ` Afzal Mohammed
2012-06-11 14:59 ` [PATCH 4/9] ARM: OMAP2+: gpmc-tusb6010: " Afzal Mohammed
2012-06-11 14:59 ` Afzal Mohammed
2012-06-13 12:27 ` Tony Lindgren [this message]
2012-06-13 12:27 ` Tony Lindgren
2012-06-13 13:14 ` Mohammed, Afzal
2012-06-13 13:14 ` Mohammed, Afzal
2012-06-11 14:59 ` [PATCH 5/9] ARM: OMAP2+: gpmc-smc91x: " Afzal Mohammed
2012-06-11 14:59 ` Afzal Mohammed
2012-06-13 12:29 ` Tony Lindgren
2012-06-13 12:29 ` Tony Lindgren
2012-06-13 13:39 ` Mohammed, Afzal
2012-06-13 13:39 ` Mohammed, Afzal
2012-06-13 13:43 ` Tony Lindgren
2012-06-13 13:43 ` Tony Lindgren
2012-06-14 9:26 ` Mohammed, Afzal
2012-06-14 9:26 ` Mohammed, Afzal
2012-06-11 14:59 ` [PATCH 6/9] ARM: OMAP2+: gpmc-smsc911x: " Afzal Mohammed
2012-06-11 14:59 ` Afzal Mohammed
2012-06-14 8:56 ` Tony Lindgren
2012-06-14 8:56 ` Tony Lindgren
2012-06-14 9:07 ` Mohammed, Afzal
2012-06-14 9:07 ` Mohammed, Afzal
2012-06-11 14:59 ` [PATCH 7/9] ARM: OMAP2+: gpmc-smsc911x: runtime time calculation Afzal Mohammed
2012-06-11 14:59 ` Afzal Mohammed
2012-06-11 14:59 ` [PATCH 8/9] ARM: OMAP2+: board omap3evm: use gpmc driver Afzal Mohammed
2012-06-11 14:59 ` Afzal Mohammed
2012-06-11 15:00 ` [PATCH 9/9] ARM: OMAP2+: board omap3beagle: " Afzal Mohammed
2012-06-11 15:00 ` Afzal Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613122747.GQ12766@atomide.com \
--to=tony@atomide.com \
--cc=afzal@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.