[Bug 34082] New: Incorrect / missing device id in radeon_atombios.c

[Bug 34082] New: Incorrect / missing device id in radeon_atombios.c

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=34082

           Summary: Incorrect / missing device id in radeon_atombios.c
           Product: Drivers
           Version: 2.5
    Kernel Version: 2.6.38+
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Video(DRI - non Intel)
        AssignedTo: drivers_video-dri@kernel-bugs.osdl.org
        ReportedBy: zhamahn@gmail.com
        Regression: No


I have an Acer TravelMate 5730, and the scenario described around line 434 in
radeon_atombios.c applies to this model as well. The problem is that the 5730
has a different device id than 5730G (at least my machine has). Changing the
relevant id from 0x95c4 to 0x9591 fixes everything for me.

Without changing the id, HDMI output works only if I turn it off with xrandr
and then use DVI (which this laptop doesn't have) and it doesn't even work that
well then, I also get lots of invalid EDID spam in dmesg.

...
Apr 28 23:00:26 localhost kernel: [ 3476.326407] [drm:radeon_dvi_detect]
*ERROR* DVI-I-1: probed a monitor but no|invalid EDID
Apr 28 23:02:19 localhost kernel: [ 3589.819736] [drm:radeon_dvi_detect]
*ERROR* HDMI-A-1: probed a monitor but no|invalid EDID
Apr 28 23:04:02 localhost kernel: [ 3692.619727] [drm:radeon_dvi_detect]
*ERROR* DVI-I-1: probed a monitor but no|invalid EDID
Apr 28 23:05:24 localhost kernel: [ 3774.783055] [drm:radeon_dvi_detect]
*ERROR* HDMI-A-1: probed a monitor but no|invalid EDID
...

This patch fixes the problems mentioned above. It just copies the entry for
5730G and changes the device id.


diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c
b/drivers/gpu/drm/radeon/radeon_atombios.c
index f5d12fb..d706df5 100644
--- a/drivers/gpu/drm/radeon/radeon_atombios.c
+++ b/drivers/gpu/drm/radeon/radeon_atombios.c
@@ -451,6 +451,18 @@ static bool radeon_atom_apply_quirks(struct drm_device
*dev,
         }
     }

+  /* Same as above, but for Acer Travelmate 5730 */
+    if ((dev->pdev->device == 0x9591) &&
+        (dev->pdev->subsystem_vendor == 0x1025) &&
+        (dev->pdev->subsystem_device == 0x013c)) {
+        if ((*connector_type == DRM_MODE_CONNECTOR_DVII) &&
+            (supported_device == ATOM_DEVICE_DFP1_SUPPORT)) {
+            /* actually it's a DVI-D port not DVI-I */
+            *connector_type = DRM_MODE_CONNECTOR_DVID;
+            return false;
+        }
+    }
+
     /* XFX Pine Group device rv730 reports no VGA DDC lines
      * even though they are wired up to record 0x93
      */

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 34082] Incorrect / missing device id in radeon_atombios.c

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=34082





--- Comment #1 from Sampo Laaksonen <zhamahn@gmail.com>  2011-04-29 10:02:26 ---
Created an attachment (id=55892)
 --> (https://bugzilla.kernel.org/attachment.cgi?id=55892)
Oops. Should have attached the patch instead of copy/paste.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 34082] Incorrect / missing device id in radeon_atombios.c

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=34082





--- Comment #2 from Alex Deucher <alexdeucher@gmail.com>  2011-04-29 16:20:38 ---
Created an attachment (id=55902)
 --> (https://bugzilla.kernel.org/attachment.cgi?id=55902)
just add the new id to the existing quirk

Here's the patch I'll be sending to Dave.  Thanks!

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 34082] Incorrect / missing device id in radeon_atombios.c

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=34082


Florian Mickler <florian@mickler.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |florian@mickler.org




--- Comment #3 from Florian Mickler <florian@mickler.org>  2011-05-10 06:34:30 ---
A patch referencing this bug report has been merged in v2.6.39-rc7:

commit 4f87af46107499415afd238be104587b5a9d7ac3
Author: Alex Deucher <alexdeucher@gmail.com>
Date:   Wed May 4 11:41:47 2011 -0400

    drm/radeon/kms: add pci id to acer travelmate quirk for 5730

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 34082] Incorrect / missing device id in radeon_atombios.c

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=34082


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |alan@lxorguk.ukuu.org.uk
         Resolution|                            |CODE_FIX




-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 34082] Incorrect / missing device id in radeon_atombios.c

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=34082


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.