From: Andi Kleen <ak@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
x86@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com
Subject: Re: [PATCH 3/4] perf, x86: check ucode before disabling PEBS on SandyBridge v3
Date: Wed, 13 Jun 2012 14:34:51 -0700 [thread overview]
Message-ID: <20120613213451.GC32604@tassilo.jf.intel.com> (raw)
In-Reply-To: <1339623054.8980.64.camel@twins>
> Stephane actually wrote:
>
> "Ok, so to close on this, I tried the 6/6/2012 ucode update on a few
> SNB-EP systems.
>
> I got two answers depending on the stepping:
> C1 (stepping 6) -> 0x618
> C2 (stepping 7) -> 0x70c
>
> So we need to check x86_mask for stepping and adjust the value of
> snb_ucode_rev accordingly for model 45."
not sure i understood your point?
What do you want me to change?
I check different numbers on the different models.
FWIW it works on a Sandy Bridge E and I believe I didn't change
the logic for non E, which Stephane tested.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2012-06-13 21:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 20:20 Updated microcode tracking and PEBS workaround patchkit Andi Kleen
2012-06-13 20:20 ` [PATCH 1/4] x86: Do microcode updates at CPU_STARTING, not CPU_ONLINE Andi Kleen
2012-06-14 11:00 ` Borislav Petkov
2012-06-14 13:54 ` Henrique de Moraes Holschuh
2012-06-13 20:20 ` [PATCH 2/4] x86: Track minimum microcode revision globally v2 Andi Kleen
2012-06-13 21:34 ` Peter Zijlstra
2012-06-13 21:39 ` Andi Kleen
2012-06-14 8:56 ` Ingo Molnar
2012-06-13 21:35 ` Peter Zijlstra
2012-06-13 21:51 ` Andi Kleen
2012-06-14 9:10 ` Borislav Petkov
2012-06-14 13:36 ` Andi Kleen
2012-06-14 12:20 ` Borislav Petkov
2012-06-14 12:37 ` Borislav Petkov
2012-06-13 20:20 ` [PATCH 3/4] perf, x86: check ucode before disabling PEBS on SandyBridge v3 Andi Kleen
2012-06-13 21:30 ` Peter Zijlstra
2012-06-13 21:34 ` Andi Kleen [this message]
2012-06-13 21:36 ` Peter Zijlstra
2012-06-13 22:34 ` Andi Kleen
2012-06-13 20:20 ` [PATCH 4/4] x86: Detect model/family mismatches for common microcode revision Andi Kleen
2012-06-14 18:02 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613213451.GC32604@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.