From: Borislav Petkov <bp@alien8.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com,
peterz@infradead.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/4] x86: Track minimum microcode revision globally v2
Date: Thu, 14 Jun 2012 14:37:59 +0200 [thread overview]
Message-ID: <20120614123759.GC13629@x1.osrc.amd.com> (raw)
In-Reply-To: <1339618842-26636-3-git-send-email-andi@firstfloor.org>
On Wed, Jun 13, 2012 at 01:20:40PM -0700, Andi Kleen wrote:
> +void update_min_microcode(struct cpuinfo_x86 *c)
> +{
> + int i;
> +
> + for_each_online_cpu (i)
> + if (cpu_data(i).microcode < c->microcode)
> + return;
> + if (boot_cpu_data.microcode != c->microcode) {
> + boot_cpu_data.microcode = c->microcode;
> + pr_info("Minimum microcode revision updated to %x\n", c->microcode);
This needs to be stating explicitly that the ucode version is in hex -
0x%x - as everywhere else in the kernel where we output ucode version.
Ditto for the remaining printks which will end up in the final version
of your patchset.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2012-06-14 12:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 20:20 Updated microcode tracking and PEBS workaround patchkit Andi Kleen
2012-06-13 20:20 ` [PATCH 1/4] x86: Do microcode updates at CPU_STARTING, not CPU_ONLINE Andi Kleen
2012-06-14 11:00 ` Borislav Petkov
2012-06-14 13:54 ` Henrique de Moraes Holschuh
2012-06-13 20:20 ` [PATCH 2/4] x86: Track minimum microcode revision globally v2 Andi Kleen
2012-06-13 21:34 ` Peter Zijlstra
2012-06-13 21:39 ` Andi Kleen
2012-06-14 8:56 ` Ingo Molnar
2012-06-13 21:35 ` Peter Zijlstra
2012-06-13 21:51 ` Andi Kleen
2012-06-14 9:10 ` Borislav Petkov
2012-06-14 13:36 ` Andi Kleen
2012-06-14 12:20 ` Borislav Petkov
2012-06-14 12:37 ` Borislav Petkov [this message]
2012-06-13 20:20 ` [PATCH 3/4] perf, x86: check ucode before disabling PEBS on SandyBridge v3 Andi Kleen
2012-06-13 21:30 ` Peter Zijlstra
2012-06-13 21:34 ` Andi Kleen
2012-06-13 21:36 ` Peter Zijlstra
2012-06-13 22:34 ` Andi Kleen
2012-06-13 20:20 ` [PATCH 4/4] x86: Detect model/family mismatches for common microcode revision Andi Kleen
2012-06-14 18:02 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120614123759.GC13629@x1.osrc.amd.com \
--to=bp@alien8.de \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.