From: Fengguang Wu <fengguang.wu@intel.com>
To: Wanpeng Li <liwp.linux@gmail.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan@kernel.org>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, trivial@kernel.org,
Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: Re: [PATCH] mm/vmscan: cleanup on the comments of do_try_to_free_pages
Date: Fri, 15 Jun 2012 10:50:32 +0800 [thread overview]
Message-ID: <20120615025032.GA8250@localhost> (raw)
In-Reply-To: <1339723524-6332-1-git-send-email-liwp.linux@gmail.com>
On Fri, Jun 15, 2012 at 09:25:24AM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
>
> Since lumpy reclaim algorithm is removed by Mel Gorman, cleanup the
> footprint of lumpy reclaim.
I think the "lumpy writeout" here does not mean "lumpy reclaim" :-)
> @@ -2065,8 +2065,9 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
> * Try to write back as many pages as we just scanned. This
> * tends to cause slow streaming writers to write data to the
> * disk smoothly, at the dirtying rate, which is nice. But
> - * that's undesirable in laptop mode, where we *want* lumpy
> - * writeout. So in laptop mode, write out the whole world.
> + * that's undesirable in laptop mode, where as much I/O as
> + * possible should be trigged if the disk needs to be spun up.
> + * So in laptop mode, write out the whole world.
> */
> writeback_threshold = sc->nr_to_reclaim + sc->nr_to_reclaim / 2;
> if (total_scanned > writeback_threshold) {
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu@intel.com>
To: Wanpeng Li <liwp.linux@gmail.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan@kernel.org>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, trivial@kernel.org,
Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: Re: [PATCH] mm/vmscan: cleanup on the comments of do_try_to_free_pages
Date: Fri, 15 Jun 2012 10:50:32 +0800 [thread overview]
Message-ID: <20120615025032.GA8250@localhost> (raw)
In-Reply-To: <1339723524-6332-1-git-send-email-liwp.linux@gmail.com>
On Fri, Jun 15, 2012 at 09:25:24AM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
>
> Since lumpy reclaim algorithm is removed by Mel Gorman, cleanup the
> footprint of lumpy reclaim.
I think the "lumpy writeout" here does not mean "lumpy reclaim" :-)
> @@ -2065,8 +2065,9 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
> * Try to write back as many pages as we just scanned. This
> * tends to cause slow streaming writers to write data to the
> * disk smoothly, at the dirtying rate, which is nice. But
> - * that's undesirable in laptop mode, where we *want* lumpy
> - * writeout. So in laptop mode, write out the whole world.
> + * that's undesirable in laptop mode, where as much I/O as
> + * possible should be trigged if the disk needs to be spun up.
> + * So in laptop mode, write out the whole world.
> */
> writeback_threshold = sc->nr_to_reclaim + sc->nr_to_reclaim / 2;
> if (total_scanned > writeback_threshold) {
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2012-06-15 2:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 1:25 [PATCH] mm/vmscan: cleanup on the comments of do_try_to_free_pages Wanpeng Li
2012-06-15 1:25 ` Wanpeng Li
2012-06-15 2:50 ` Fengguang Wu [this message]
2012-06-15 2:50 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615025032.GA8250@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwp.linux@gmail.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=shangw@linux.vnet.ibm.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.