From: Dan Carpenter <dan.carpenter@oracle.com>
To: Fengguang Wu <wfg@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: automated warning notifications
Date: Fri, 15 Jun 2012 07:12:22 +0000 [thread overview]
Message-ID: <20120615071222.GZ13539@mwanda> (raw)
In-Reply-To: <20120615014835.GA5695@localhost>
On Fri, Jun 15, 2012 at 09:48:35AM +0800, Fengguang Wu wrote:
> The lots of false warnings are a big problem. It makes the automated
> notification more noises than signals to people. So I end up disabling
> the sparse check totally..
>
I do a basic sanity check of my emails before I send them.
Sometimes I do send false positives. If the warning is introduced
by a very new code then probably the patch author can answer my
question off the top of her head. Also I send some false positives
just to try learn what the rules are.
> In an average working day, 1-2 build errors will be caught and email
> notified. I guess there will be more sparse warnings if it's turned
> on.
>
> Perhaps the sparse warnings can be enabled, but only sent to the patch
> author. If you and anyone else are interested, they could be sent to
> some mailing list, too. One thing I'm sure is, we probably never want
> to disturb the busy maintainers with these warnings.
Eventually I think we will want to set up a mailing list for this or
we will start sending duplicate messages.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Fengguang Wu <wfg@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: automated warning notifications
Date: Fri, 15 Jun 2012 10:12:22 +0300 [thread overview]
Message-ID: <20120615071222.GZ13539@mwanda> (raw)
In-Reply-To: <20120615014835.GA5695@localhost>
On Fri, Jun 15, 2012 at 09:48:35AM +0800, Fengguang Wu wrote:
> The lots of false warnings are a big problem. It makes the automated
> notification more noises than signals to people. So I end up disabling
> the sparse check totally..
>
I do a basic sanity check of my emails before I send them.
Sometimes I do send false positives. If the warning is introduced
by a very new code then probably the patch author can answer my
question off the top of her head. Also I send some false positives
just to try learn what the rules are.
> In an average working day, 1-2 build errors will be caught and email
> notified. I guess there will be more sparse warnings if it's turned
> on.
>
> Perhaps the sparse warnings can be enabled, but only sent to the patch
> author. If you and anyone else are interested, they could be sent to
> some mailing list, too. One thing I'm sure is, we probably never want
> to disturb the busy maintainers with these warnings.
Eventually I think we will want to set up a mailing list for this or
we will start sending duplicate messages.
regards,
dan carpenter
next prev parent reply other threads:[~2012-06-15 7:12 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 17:25 automated warning notifications Dan Carpenter
2012-06-14 17:25 ` Dan Carpenter
2012-06-15 1:48 ` Fengguang Wu
2012-06-15 1:48 ` Fengguang Wu
2012-06-15 7:12 ` Dan Carpenter [this message]
2012-06-15 7:12 ` Dan Carpenter
2012-06-15 7:58 ` Fengguang Wu
2012-06-15 7:58 ` Fengguang Wu
2012-06-15 8:31 ` Josh Triplett
2012-06-15 8:31 ` Josh Triplett
2012-06-15 8:54 ` Fengguang Wu
2012-06-15 8:54 ` Fengguang Wu
2012-06-15 16:48 ` Randy Dunlap
2012-06-15 16:48 ` Randy Dunlap
2012-06-16 9:17 ` Fengguang Wu
2012-06-16 9:17 ` Fengguang Wu
2012-06-16 17:44 ` Randy Dunlap
2012-06-16 17:44 ` Randy Dunlap
2012-06-15 10:40 ` Julia Lawall
2012-06-15 10:40 ` Julia Lawall
2012-06-15 11:19 ` Dan Carpenter
2012-06-15 11:19 ` Dan Carpenter
2012-06-15 13:33 ` Peter Senna Tschudin
2012-06-15 13:33 ` Peter Senna Tschudin
2012-06-15 13:53 ` Dan Carpenter
2012-06-15 13:53 ` Dan Carpenter
2012-06-15 15:49 ` Peter Senna Tschudin
2012-06-15 15:49 ` Peter Senna Tschudin
2012-06-15 14:34 ` Fengguang Wu
2012-06-15 14:34 ` Fengguang Wu
2012-06-16 7:50 ` Cong Wang
2012-06-16 7:50 ` Cong Wang
2012-06-16 9:01 ` Fengguang Wu
2012-06-16 9:01 ` Fengguang Wu
2012-07-02 12:45 ` Dan Carpenter
2012-07-02 12:45 ` Dan Carpenter
2012-07-06 3:07 ` Fengguang Wu
2012-07-06 3:07 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615071222.GZ13539@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wfg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.