All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sangbeom Kim <sbkim73@samsung.com>
Cc: "'Liam Girdwood'" <lrg@ti.com>,
	linux-kernel@vger.kernel.org, sameo@linux.intel.com,
	sbkim01@gmail.com
Subject: Re: [PATCH 5/5] regulator: Support AP watchdog reset operation for s5m8767a
Date: Sun, 17 Jun 2012 19:53:05 +0100	[thread overview]
Message-ID: <20120617185305.GD4267@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <04ad01cd49c0$df565d20$9e031760$@com>

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

On Thu, Jun 14, 2012 at 09:01:39AM +0900, Sangbeom Kim wrote:

> Solution
> - Basic concept: After ap watchdog reset, GPIO configuration is changed by default value
> - S5M8767A has function of voltage control with gpio (8 levels with 3 gpios)
> - Set bootable voltage on level 0 -> can work with default gpio configuration
> - In the probing, Change voltage control level from level 0 to level 1
> - Execute normal dvfs operation on level 1
> - After watchdog reset, ap gpio is set by default value
> - PMIC operation mode is changed by ap reset (level1 -> level0)
> - AP can execute normal boot

OK, so basically what you're doing is fixing one of the GPIO selected
voltage levels so that when the AP comes out of reset it'll drive the
PMIC into a suitable level for it to boot?  That makes sense - can you
please resend with this in the changelog.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-06-17 18:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-13  8:28 [PATCH 5/5] regulator: Support AP watchdog reset operation for s5m8767a Sangbeom Kim
2012-06-13 17:46 ` Mark Brown
2012-06-14  0:01   ` Sangbeom Kim
2012-06-17 18:53     ` Mark Brown [this message]
2012-06-17 23:56       ` Sangbeom Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120617185305.GD4267@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=sameo@linux.intel.com \
    --cc=sbkim01@gmail.com \
    --cc=sbkim73@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.