* [patch] ASoC: Ux500: unlock on an error path
@ 2012-06-16 13:19 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-06-16 13:19 UTC (permalink / raw)
To: Liam Girdwood
Cc: Ola Lilja, alsa-devel, Takashi Iwai, Linus Walleij, Mark Brown,
kernel-janitors
There is a missing mutex_unlock() here. The cleanup path also has more
debug output.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c
index 389dd66..3c79592 100644
--- a/sound/soc/codecs/ab8500-codec.c
+++ b/sound/soc/codecs/ab8500-codec.c
@@ -1235,7 +1235,8 @@ static int anc_status_control_put(struct snd_kcontrol *kcontrol,
req != ANC_APPLY_IIR) {
dev_err(dev, "%s: ERROR: Unsupported status to set '%s'!\n",
__func__, enum_anc_state[req]);
- return -EINVAL;
+ status = -EINVAL;
+ goto cleanup;
}
apply_fir = req == ANC_APPLY_FIR || req == ANC_APPLY_FIR_IIR;
apply_iir = req == ANC_APPLY_IIR || req == ANC_APPLY_FIR_IIR;
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] ASoC: Ux500: unlock on an error path
@ 2012-06-16 13:19 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-06-16 13:19 UTC (permalink / raw)
To: Liam Girdwood
Cc: Ola Lilja, alsa-devel, Takashi Iwai, Linus Walleij, Mark Brown,
kernel-janitors
There is a missing mutex_unlock() here. The cleanup path also has more
debug output.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c
index 389dd66..3c79592 100644
--- a/sound/soc/codecs/ab8500-codec.c
+++ b/sound/soc/codecs/ab8500-codec.c
@@ -1235,7 +1235,8 @@ static int anc_status_control_put(struct snd_kcontrol *kcontrol,
req != ANC_APPLY_IIR) {
dev_err(dev, "%s: ERROR: Unsupported status to set '%s'!\n",
__func__, enum_anc_state[req]);
- return -EINVAL;
+ status = -EINVAL;
+ goto cleanup;
}
apply_fir = req = ANC_APPLY_FIR || req = ANC_APPLY_FIR_IIR;
apply_iir = req = ANC_APPLY_IIR || req = ANC_APPLY_FIR_IIR;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] ASoC: Ux500: unlock on an error path
2012-06-16 13:19 ` Dan Carpenter
@ 2012-06-17 19:49 ` Mark Brown
-1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-06-17 19:49 UTC (permalink / raw)
To: Dan Carpenter
Cc: Ola Lilja, alsa-devel, Takashi Iwai, Linus Walleij,
kernel-janitors, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 171 bytes --]
On Sat, Jun 16, 2012 at 04:19:27PM +0300, Dan Carpenter wrote:
> There is a missing mutex_unlock() here. The cleanup path also has more
> debug output.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] ASoC: Ux500: unlock on an error path
@ 2012-06-17 19:49 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-06-17 19:49 UTC (permalink / raw)
To: Dan Carpenter
Cc: Ola Lilja, alsa-devel, Takashi Iwai, Linus Walleij,
kernel-janitors, Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
On Sat, Jun 16, 2012 at 04:19:27PM +0300, Dan Carpenter wrote:
> There is a missing mutex_unlock() here. The cleanup path also has more
> debug output.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-06-17 19:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-16 13:19 [patch] ASoC: Ux500: unlock on an error path Dan Carpenter
2012-06-16 13:19 ` Dan Carpenter
2012-06-17 19:49 ` Mark Brown
2012-06-17 19:49 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.