From: Robert Richter <robert.richter@amd.com>
To: Stephane Eranian <eranian@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jim Cromie <jim.cromie@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] perf stat: Fix default logfd to use stderr
Date: Tue, 19 Jun 2012 13:31:58 +0200 [thread overview]
Message-ID: <20120619113158.GB1478@erda.amd.com> (raw)
In-Reply-To: <CABPqkBQA+CDxzp_g2Lu=Uoet5oqOq5E_1eiATGfoX=d7xEO49g@mail.gmail.com>
On 19.06.12 08:09:31, Stephane Eranian wrote:
> On Tue, Jun 19, 2012 at 4:13 AM, Namhyung Kim <namhyung@kernel.org> wrote:
> > Hi, Robert
> >
> > On Mon, 18 Jun 2012 16:51:08 +0200, Robert Richter wrote:
> >> On 29.09.11 18:48:01, Arnaldo Carvalho de Melo wrote:
> >>> From: Jim Cromie <jim.cromie@gmail.com>
> >>>
> >>> This perf stat option emulates valgrind's --log-fd option, allowing the
> >>> user to send perf results elsewhere, and leaving stderr for use by the
> >>> program under test. This complements --output file option, and is
> >>> mutually exclusive with it.
> >>>
> >>> 3>results perf stat --log-fd 3 -- $cmd
> >>> 3>>results perf stat --log-fd 3 --append -- $cmd
> >>>
> >>> The perl distro's make test.valgrind target uses valgrind's --log-fd
> >>> option, I've adapted it to invoke perf also, and tested this patch
> >>> there.
> >>>
> >>> Link: http://lkml.kernel.org/r/1315437244-3788-2-git-send-email-jim.cromie@gmail.com
> >>> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >>> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> >>> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >>
> >> With certain shell redirections this (56f3bae) fails with a log fd
> >> setup failure. Fix below.
> >>
> >
> > It looks somewhat related to Stephane's patch. Can you we check it too?
> >
> > http://lkml.indiana.edu/hypermail/linux/kernel/1205.1/04232.html
I applied the patch to my tree and this works too. Both patches
basically avoid fdopen() if a log-fd option is not given.
After reviewing the code again I noticed my code breaks the -o option.
So Stephane's patch is fine for me too, except for the fact that
--log-fd 0 is ignored. Maybe we change this by initializing output_fd
with -1 and modify the checks of output_fd?
> Yes, my patch is needed and it was posted over a month ago now.....
> Arnaldo, please apply my patch.
It is in the pull request for Ingo.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
WARNING: multiple messages have this Message-ID (diff)
From: Robert Richter <robert.richter@amd.com>
To: Stephane Eranian <eranian@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jim Cromie <jim.cromie@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] perf stat: Fix default logfd to use stderr
Date: Tue, 19 Jun 2012 13:31:58 +0200 [thread overview]
Message-ID: <20120619113158.GB1478@erda.amd.com> (raw)
In-Reply-To: <CABPqkBQA+CDxzp_g2Lu=Uoet5oqOq5E_1eiATGfoX=d7xEO49g@mail.gmail.com>
On 19.06.12 08:09:31, Stephane Eranian wrote:
> On Tue, Jun 19, 2012 at 4:13 AM, Namhyung Kim <namhyung@kernel.org> wrote:
> > Hi, Robert
> >
> > On Mon, 18 Jun 2012 16:51:08 +0200, Robert Richter wrote:
> >> On 29.09.11 18:48:01, Arnaldo Carvalho de Melo wrote:
> >>> From: Jim Cromie <jim.cromie@gmail.com>
> >>>
> >>> This perf stat option emulates valgrind's --log-fd option, allowing the
> >>> user to send perf results elsewhere, and leaving stderr for use by the
> >>> program under test. �This complements --output file option, and is
> >>> mutually exclusive with it.
> >>>
> >>> � �3>results �perf stat --log-fd 3 � � � � �-- $cmd
> >>> � �3>>results perf stat --log-fd 3 --append -- $cmd
> >>>
> >>> The perl distro's make test.valgrind target uses valgrind's --log-fd
> >>> option, I've adapted it to invoke perf also, and tested this patch
> >>> there.
> >>>
> >>> Link: http://lkml.kernel.org/r/1315437244-3788-2-git-send-email-jim.cromie@gmail.com
> >>> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >>> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> >>> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >>
> >> With certain shell redirections this (56f3bae) fails with a log fd
> >> setup failure. Fix below.
> >>
> >
> > It looks somewhat related to Stephane's patch. Can you we check it too?
> >
> > http://lkml.indiana.edu/hypermail/linux/kernel/1205.1/04232.html
I applied the patch to my tree and this works too. Both patches
basically avoid fdopen() if a log-fd option is not given.
After reviewing the code again I noticed my code breaks the -o option.
So Stephane's patch is fine for me too, except for the fact that
--log-fd 0 is ignored. Maybe we change this by initializing output_fd
with -1 and modify the checks of output_fd?
> Yes, my patch is needed and it was posted over a month ago now.....
> Arnaldo, please apply my patch.
It is in the pull request for Ingo.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
next prev parent reply other threads:[~2012-06-19 11:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 22:47 [GIT PULL 00/16] perf/core improvements and fixes Arnaldo Carvalho de Melo
2011-09-29 22:47 ` [PATCH 01/16] perf symbols: Stop using 'self' in map_groups__ methods Arnaldo Carvalho de Melo
2011-09-29 22:47 ` [PATCH 02/16] perf script: Add drop monitor script Arnaldo Carvalho de Melo
2011-09-29 22:47 ` [PATCH 03/16] perf buildid-list: Add option to show the running kernel build id Arnaldo Carvalho de Melo
2011-09-29 22:47 ` [PATCH 04/16] perf buildid-list: Support showing the build id in an ELF file Arnaldo Carvalho de Melo
2011-09-29 22:47 ` [PATCH 05/16] perf top browser: Fix up line width calculation Arnaldo Carvalho de Melo
2011-09-29 22:48 ` [PATCH 06/16] perf top: Improve lost events warning Arnaldo Carvalho de Melo
2011-09-29 22:48 ` [PATCH 07/16] perf stat: Add --log-fd <N> option to redirect stderr elsewhere Arnaldo Carvalho de Melo
2012-06-18 14:51 ` [PATCH] perf stat: Fix default logfd to use stderr Robert Richter
2012-06-19 2:13 ` Namhyung Kim
2012-06-19 6:09 ` Stephane Eranian
2012-06-19 11:31 ` Robert Richter [this message]
2012-06-19 11:31 ` Robert Richter
2012-06-19 11:34 ` Arnaldo Carvalho de Melo
2012-06-20 12:23 ` Stephane Eranian
2011-09-29 22:48 ` [PATCH 08/16] perf stat: Fix +- nan% in --no-aggr runs Arnaldo Carvalho de Melo
2011-09-29 22:48 ` [PATCH 09/16] perf stat: Suppress printing std-dev when its 0 Arnaldo Carvalho de Melo
2011-09-29 22:48 ` [PATCH 10/16] perf stat: Allow tab as cvs delimiter Arnaldo Carvalho de Melo
2011-10-09 20:58 ` Paul Bolle
2011-09-29 22:48 ` [PATCH 11/16] perf stat: Fix spelling in comment Arnaldo Carvalho de Melo
2011-09-29 22:48 ` [PATCH 12/16] perf tools: Make stat/record print fatal signals of the target program Arnaldo Carvalho de Melo
2011-09-29 22:48 ` [PATCH 13/16] perf: Support setting the disassembler style Arnaldo Carvalho de Melo
2011-09-29 22:48 ` [PATCH 14/16] perf report: Fix stdio event name header printing Arnaldo Carvalho de Melo
2011-09-29 22:48 ` [PATCH 15/16] perf sched: Fix script command documentation Arnaldo Carvalho de Melo
2011-09-29 22:48 ` [PATCH 16/16] perf symbols: Treat all memory maps without dso file as loaded Arnaldo Carvalho de Melo
2011-10-04 7:57 ` [GIT PULL 00/16] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120619113158.GB1478@erda.amd.com \
--to=robert.richter@amd.com \
--cc=acme@infradead.org \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.