From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP2: twl-common: Fix compiler warning
Date: Wed, 20 Jun 2012 07:25:16 -0700 [thread overview]
Message-ID: <20120620142515.GQ12766@atomide.com> (raw)
In-Reply-To: <1339767234-25323-1-git-send-email-peter.ujfalusi@ti.com>
* Peter Ujfalusi <peter.ujfalusi@ti.com> [120615 06:38]:
> If the kernel is built only for OMAP2 the following warning will show up:
>
> arch/arm/mach-omap2/twl-common.c:52: warning: ‘twl_set_voltage’ defined but not used
> arch/arm/mach-omap2/twl-common.c:58: warning: ‘twl_get_voltage’ defined but not used
>
> The twl_set/get_voltage callbacks only used when OMAP3/4 is selected.
Thanks applying into fixes.
Tony
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> arch/arm/mach-omap2/twl-common.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c
> index 119d5a9..5447c13 100644
> --- a/arch/arm/mach-omap2/twl-common.c
> +++ b/arch/arm/mach-omap2/twl-common.c
> @@ -48,6 +48,7 @@ static struct i2c_board_info __initdata omap4_i2c1_board_info[] = {
> },
> };
>
> +#if defined(CONFIG_ARCH_OMAP3) || defined(CONFIG_ARCH_OMAP4)
> static int twl_set_voltage(void *data, int target_uV)
> {
> struct voltagedomain *voltdm = (struct voltagedomain *)data;
> @@ -59,6 +60,7 @@ static int twl_get_voltage(void *data)
> struct voltagedomain *voltdm = (struct voltagedomain *)data;
> return voltdm_get_voltage(voltdm);
> }
> +#endif
>
> void __init omap_pmic_init(int bus, u32 clkrate,
> const char *pmic_type, int pmic_irq,
> --
> 1.7.8.6
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2: twl-common: Fix compiler warning
Date: Wed, 20 Jun 2012 07:25:16 -0700 [thread overview]
Message-ID: <20120620142515.GQ12766@atomide.com> (raw)
In-Reply-To: <1339767234-25323-1-git-send-email-peter.ujfalusi@ti.com>
* Peter Ujfalusi <peter.ujfalusi@ti.com> [120615 06:38]:
> If the kernel is built only for OMAP2 the following warning will show up:
>
> arch/arm/mach-omap2/twl-common.c:52: warning: ?twl_set_voltage? defined but not used
> arch/arm/mach-omap2/twl-common.c:58: warning: ?twl_get_voltage? defined but not used
>
> The twl_set/get_voltage callbacks only used when OMAP3/4 is selected.
Thanks applying into fixes.
Tony
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> arch/arm/mach-omap2/twl-common.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c
> index 119d5a9..5447c13 100644
> --- a/arch/arm/mach-omap2/twl-common.c
> +++ b/arch/arm/mach-omap2/twl-common.c
> @@ -48,6 +48,7 @@ static struct i2c_board_info __initdata omap4_i2c1_board_info[] = {
> },
> };
>
> +#if defined(CONFIG_ARCH_OMAP3) || defined(CONFIG_ARCH_OMAP4)
> static int twl_set_voltage(void *data, int target_uV)
> {
> struct voltagedomain *voltdm = (struct voltagedomain *)data;
> @@ -59,6 +60,7 @@ static int twl_get_voltage(void *data)
> struct voltagedomain *voltdm = (struct voltagedomain *)data;
> return voltdm_get_voltage(voltdm);
> }
> +#endif
>
> void __init omap_pmic_init(int bus, u32 clkrate,
> const char *pmic_type, int pmic_irq,
> --
> 1.7.8.6
>
next prev parent reply other threads:[~2012-06-20 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 13:33 [PATCH] ARM: OMAP2: twl-common: Fix compiler warning Peter Ujfalusi
2012-06-15 13:33 ` Peter Ujfalusi
2012-06-20 14:25 ` Tony Lindgren [this message]
2012-06-20 14:25 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620142515.GQ12766@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.