All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: 'Mark Brown' <broonie@opensource.wolfsonmicro.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ARM: S3C64XX: Add IRQ mapping for wm0010 on Cragganmore
Date: Wed, 20 Jun 2012 17:02:10 +0100	[thread overview]
Message-ID: <20120620160210.GA27145@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <028c01cd4e9d$16c0f9b0$4442ed10$%kim@samsung.com>

On Wed, Jun 20, 2012 at 01:28:06PM +0900, Kukjin Kim wrote:
> Kukjin Kim wrote:
> > 
> > Dimitris Papastamos wrote:
> > >
> > > Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
> > > ---
> > >  arch/arm/mach-s3c64xx/mach-crag6410-module.c |    1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c
> > b/arch/arm/mach-
> > > s3c64xx/mach-crag6410-module.c
> > > index f347336..7c8ea3c 100644
> > > --- a/arch/arm/mach-s3c64xx/mach-crag6410-module.c
> > > +++ b/arch/arm/mach-s3c64xx/mach-crag6410-module.c
> > > @@ -47,6 +47,7 @@ static struct spi_board_info wm1253_devs[] = {
> > >  		.bus_num	= 0,
> > >  		.chip_select	= 0,
> > >  		.mode		= SPI_MODE_0,
> > > +		.irq            = S3C_EINT(5),
>                     ^^^^^^^^^^^^
> If there is no reason, using tab is better at the mark ^

Oops, yes tabs there, will re-send.

> > >  		.controller_data = &wm0010_spi_csinfo,
> > >  		.platform_data = &wm0010_crag_pdata,
> 
> I can't find platform_data in my tree (just v3.5-rc3), there is another
> patch?
> 
> Now, just applying this patch is ok?

Applying this patch should be fine.

Thanks,
Dimitris

WARNING: multiple messages have this Message-ID (diff)
From: dp@opensource.wolfsonmicro.com (Dimitris Papastamos)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S3C64XX: Add IRQ mapping for wm0010 on Cragganmore
Date: Wed, 20 Jun 2012 17:02:10 +0100	[thread overview]
Message-ID: <20120620160210.GA27145@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <028c01cd4e9d$16c0f9b0$4442ed10$%kim@samsung.com>

On Wed, Jun 20, 2012 at 01:28:06PM +0900, Kukjin Kim wrote:
> Kukjin Kim wrote:
> > 
> > Dimitris Papastamos wrote:
> > >
> > > Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
> > > ---
> > >  arch/arm/mach-s3c64xx/mach-crag6410-module.c |    1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c
> > b/arch/arm/mach-
> > > s3c64xx/mach-crag6410-module.c
> > > index f347336..7c8ea3c 100644
> > > --- a/arch/arm/mach-s3c64xx/mach-crag6410-module.c
> > > +++ b/arch/arm/mach-s3c64xx/mach-crag6410-module.c
> > > @@ -47,6 +47,7 @@ static struct spi_board_info wm1253_devs[] = {
> > >  		.bus_num	= 0,
> > >  		.chip_select	= 0,
> > >  		.mode		= SPI_MODE_0,
> > > +		.irq            = S3C_EINT(5),
>                     ^^^^^^^^^^^^
> If there is no reason, using tab is better at the mark ^

Oops, yes tabs there, will re-send.

> > >  		.controller_data = &wm0010_spi_csinfo,
> > >  		.platform_data = &wm0010_crag_pdata,
> 
> I can't find platform_data in my tree (just v3.5-rc3), there is another
> patch?
> 
> Now, just applying this patch is ok?

Applying this patch should be fine.

Thanks,
Dimitris

  reply	other threads:[~2012-06-20 16:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1339775065-13211-1-git-send-email-dp@opensource.wolfsonmicro.com>
2012-06-19  8:50 ` [PATCH] ARM: S3C64XX: Add IRQ mapping for wm0010 on Cragganmore Kukjin Kim
2012-06-19  8:50   ` Kukjin Kim
2012-06-20  4:28 ` Kukjin Kim
2012-06-20  4:28   ` Kukjin Kim
2012-06-20 16:02   ` Dimitris Papastamos [this message]
2012-06-20 16:02     ` Dimitris Papastamos
2012-06-20 18:28     ` Kukjin Kim
2012-06-20 18:28       ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120620160210.GA27145@opensource.wolfsonmicro.com \
    --to=dp@opensource.wolfsonmicro.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.