From: Ingo Molnar <mingo@kernel.org>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: Borislav Petkov <borislav.petkov@amd.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Jean Delvare <khali@linux-fr.org>,
x86@kernel.org, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] x86, cpufeature: Fix duplicate feature name "dts"
Date: Fri, 22 Jun 2012 08:59:37 +0200 [thread overview]
Message-ID: <20120622065937.GA22167@gmail.com> (raw)
In-Reply-To: <4FE37FE9.6000107@linux.intel.com>
* H. Peter Anvin <hpa@linux.intel.com> wrote:
> On 06/21/2012 11:44 AM, Borislav Petkov wrote:
> > On Thu, Jun 21, 2012 at 11:06:04AM -0700, H. Peter Anvin wrote:
> >> On 06/21/2012 10:07 AM, Jean Delvare wrote:
> >>>
> >>> And FWIW, X86_FEATURE_DS has no user in the kernel. Doesn't look like a
> >>> key feature to me, but maybe my view is biased...
> >>>
> >>
> >> No, but apparently perfmon2 depends on it, in userspace, and it relies
> >> on the string.
> >>
> >> So this is a nonstarter.
> >
> > Maybe call the sensor thing "dtsen" or something similarly short but not
> > "dts"?
> >
>
> Yeah, that's what we have to do. Sigh.
Plus add a kernel build time check to avoid such string clashes
in the future? These acronyms tend to be short and hard to read,
I'd not be surprised if this repeated in the future.
Thanks,
Ingo
next prev parent reply other threads:[~2012-06-22 6:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 14:28 [PATCH] x86, cpufeature: Fix duplicate feature name "dts" Jean Delvare
2012-06-21 16:28 ` H. Peter Anvin
2012-06-21 17:07 ` Jean Delvare
2012-06-21 18:06 ` H. Peter Anvin
2012-06-21 18:44 ` Borislav Petkov
2012-06-21 20:11 ` H. Peter Anvin
2012-06-22 6:59 ` Ingo Molnar [this message]
2012-06-22 18:01 ` H. Peter Anvin
2012-06-22 18:49 ` Guenter Roeck
2012-06-22 7:02 ` Jan Beulich
2012-06-22 13:38 ` H. Peter Anvin
2012-06-22 20:38 ` [tip:x86/urgent] x86, cpufeature: Rename X86_FEATURE_DTS to X86_FEATURE_DTHERM tip-bot for H. Peter Anvin
2012-06-24 19:49 ` Jean Delvare
2012-06-24 20:37 ` H. Peter Anvin
2012-06-26 9:13 ` Jean Delvare
2012-06-24 20:39 ` H. Peter Anvin
2012-06-24 20:59 ` H. Peter Anvin
2012-06-22 20:39 ` [tip:x86/urgent] x86, cpufeature: Catch duplicate CPU feature strings tip-bot for H. Peter Anvin
2012-06-25 16:13 ` [tip:x86/urgent] x86, cpufeature: Rename X86_FEATURE_DTS to X86_FEATURE_DTHERM tip-bot for H. Peter Anvin
2012-06-25 16:14 ` [tip:x86/urgent] x86, cpufeature: Catch duplicate CPU feature strings tip-bot for H. Peter Anvin
2012-06-26 12:32 ` Jean Delvare
2012-06-26 14:48 ` H. Peter Anvin
2012-06-26 15:20 ` [tip:x86/urgent] x86, cpufeature: Remove stray %s, add -w to mkcapflags.pl tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120622065937.GA22167@gmail.com \
--to=mingo@kernel.org \
--cc=JBeulich@suse.com \
--cc=borislav.petkov@amd.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.