From: "H. Peter Anvin" <hpa@zytor.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
JBeulich@suse.com, tglx@linutronix.de, hpa@linux.intel.com,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86, cpufeature: Catch duplicate CPU feature strings
Date: Tue, 26 Jun 2012 07:48:04 -0700 [thread overview]
Message-ID: <4FE9CBA4.3020601@zytor.com> (raw)
In-Reply-To: <20120626143246.0c9bf301@endymion.delvare>
On 06/26/2012 05:32 AM, Jean Delvare wrote:
>
> You added an extra %s in the string, can't think of a good reason for
> it. perl -w would have told you, I think we should add it.
>
Ah yes, a leftover from testing.
> Other than this, the code looks good and the improvement reasonable, so
> you can add:
>
> Acked-by: Jean Delvare <khali@linux-fr.org>
>
Should probably be reviewed-by: but nevertheless...
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-06-26 14:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 14:28 [PATCH] x86, cpufeature: Fix duplicate feature name "dts" Jean Delvare
2012-06-21 16:28 ` H. Peter Anvin
2012-06-21 17:07 ` Jean Delvare
2012-06-21 18:06 ` H. Peter Anvin
2012-06-21 18:44 ` Borislav Petkov
2012-06-21 20:11 ` H. Peter Anvin
2012-06-22 6:59 ` Ingo Molnar
2012-06-22 18:01 ` H. Peter Anvin
2012-06-22 18:49 ` Guenter Roeck
2012-06-22 7:02 ` Jan Beulich
2012-06-22 13:38 ` H. Peter Anvin
2012-06-22 20:38 ` [tip:x86/urgent] x86, cpufeature: Rename X86_FEATURE_DTS to X86_FEATURE_DTHERM tip-bot for H. Peter Anvin
2012-06-24 19:49 ` Jean Delvare
2012-06-24 20:37 ` H. Peter Anvin
2012-06-26 9:13 ` Jean Delvare
2012-06-24 20:39 ` H. Peter Anvin
2012-06-24 20:59 ` H. Peter Anvin
2012-06-22 20:39 ` [tip:x86/urgent] x86, cpufeature: Catch duplicate CPU feature strings tip-bot for H. Peter Anvin
2012-06-25 16:13 ` [tip:x86/urgent] x86, cpufeature: Rename X86_FEATURE_DTS to X86_FEATURE_DTHERM tip-bot for H. Peter Anvin
2012-06-25 16:14 ` [tip:x86/urgent] x86, cpufeature: Catch duplicate CPU feature strings tip-bot for H. Peter Anvin
2012-06-26 12:32 ` Jean Delvare
2012-06-26 14:48 ` H. Peter Anvin [this message]
2012-06-26 15:20 ` [tip:x86/urgent] x86, cpufeature: Remove stray %s, add -w to mkcapflags.pl tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE9CBA4.3020601@zytor.com \
--to=hpa@zytor.com \
--cc=JBeulich@suse.com \
--cc=hpa@linux.intel.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.