From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Rajeev kumar <rajeev-dlh.kumar@st.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH V2 2/9] sound:asoc: Add support for STA529 Audio Codec
Date: Fri, 22 Jun 2012 09:49:19 +0100 [thread overview]
Message-ID: <20120622084918.GE4037@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FE41021.3060605@st.com>
[-- Attachment #1.1: Type: text/plain, Size: 612 bytes --]
On Fri, Jun 22, 2012 at 11:56:41AM +0530, Rajeev kumar wrote:
> On 6/21/2012 5:55 PM, Mark Brown wrote:
> >>+static int sta529_resume(struct snd_soc_codec *codec)
> >>> +{
> >>> + snd_soc_cache_sync(codec);
> >You're not using the ASoC cache code.
> Point is not clear to me, you mean to say I need to use
> regcache_sync(sta529->regmap), please confirm.
You shouldn't be calling ASoC cache functions at all since you're not
using an ASoC cache. There's no point in doing anything here as you're
doing your cache management in set_bias_level() but if you were then yes
you should be using regcache_sync().
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-06-22 8:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 10:24 [PATCH V2 0/9] Add ASoC drivers for SPEAr platform & I2S driver for Designware module Rajeev Kumar
2012-06-21 10:24 ` [PATCH V2 1/9] sound:asoc: Add support for spdif in Audio Codec Rajeev Kumar
2012-06-22 9:21 ` Mark Brown
2012-06-22 9:44 ` Rajeev kumar
2012-06-22 9:49 ` Mark Brown
2012-06-22 9:54 ` Rajeev kumar
2012-06-21 10:24 ` [PATCH V2 2/9] sound:asoc: Add support for STA529 " Rajeev Kumar
2012-06-21 12:25 ` Mark Brown
2012-06-22 6:26 ` Rajeev kumar
2012-06-22 8:49 ` Mark Brown [this message]
2012-06-21 10:24 ` [PATCH V2 3/9] sound:asoc: Add support for synopsys i2s controller as per ASoC framework Rajeev Kumar
2012-06-22 9:25 ` Mark Brown
2012-06-22 9:43 ` Rajeev kumar
2012-06-21 10:24 ` [PATCH V2 4/9] sound:asoc: Add support for SPEAr ASoC pcm layer Rajeev Kumar
2012-06-22 9:28 ` Mark Brown
2012-06-22 9:37 ` Rajeev kumar
2012-06-21 10:24 ` [PATCH V2 5/9] sound:asoc:spdif_in: Add spdif IN support Rajeev Kumar
2012-06-23 10:55 ` Mark Brown
2012-06-21 10:24 ` [PATCH V2 6/9] sound:asoc:spdif_out: Add spdif out support Rajeev Kumar
2012-06-23 10:56 ` Mark Brown
2012-06-21 10:24 ` [PATCH V2 7/9] sound:asoc: Add support for SPEAr ASoC machine driver Rajeev Kumar
2012-06-23 11:01 ` Mark Brown
2012-06-25 10:28 ` Rajeev kumar
2012-06-27 4:37 ` Rajeev kumar
2012-06-27 11:12 ` Mark Brown
2012-06-21 10:24 ` [PATCH V2 8/9] sound:asoc: Add Kconfig and Makefile to support SPEAr audio driver Rajeev Kumar
2012-06-21 10:24 ` [PATCH V2 9/9] sound:asoc: Update Kconfig and Makefile(sound/soc/) to support SPEAr audio Rajeev Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120622084918.GE4037@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=rajeev-dlh.kumar@st.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.