Re: [PATCH V2 7/9] sound:asoc: Add support for SPEAr ASoC machine driver.

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

[-- Attachment #1.1: Type: text/plain, Size: 955 bytes --]

On Thu, Jun 21, 2012 at 03:54:55PM +0530, Rajeev Kumar wrote:

> +	/* set codec DAI configuration */
> +	ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S |
> +			SND_SOC_DAIFMT_CBS_CFM);

You can se this in the dai_link structure rather than having to set it
in hw_params() every time.

> +static struct platform_driver spear_evb_driver = {
> +       .driver = {
> +               .name = "spear-evb",
> +               .owner = THIS_MODULE,
> +               .pm = &snd_soc_pm_ops,
> +       },
> +       .probe = spear_evb_probe,
> +       .remove = __devexit_p(spear_evb_remove),
> +};

I'd expect to see an of_match_table in the device too given that you're
parsing OF compatible data.  Given how simple this is I wonder if you
can instead add DT support to the simple-card driver which Morimoto-san
recently contributed rather than adding a new driver?

> +MODULE_ALIAS("platform:spear evb");

This won't match against anything in the driver.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]