Re: [squashfs] Who is responsible for code review?

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Jun 23, 2012 at 03:01:27AM +0100, Phillip Lougher wrote:
> On Fri, Jun 22, 2012 at 11:53 AM, Vyacheslav Dubeyko <slava@dubeyko.com> wrote:
> > Hi,
> >
> >> We have a script to answer such questions.
> >> scripts/get_maintainer.pl
> >>
> > Ok. Thanks. :-)
> >
> > I know that Phillip Lougher is the maintainer of squashfs file system
> > code. But he keeps silence during last time. It was patch from UCHINO
> > Satoshi recently but nobody said YES or NO on it. My question is about
> > such situation.
> >
> 
>  Vyacheslav
> 
> You wrote "but nobody said YES or NO on it", and effectively answered
> your own question.  The silence has been waiting for
> feedback/code-review on these patches from others.
> 
>  The patches in question are adding a new feature to Squashfs.  New
> features are always nice to have, but always carry the risk of
> introducing bugs, performance regressions, and generally making the
> code harder to maintain if (as is the case with these patches)  they
> have been implemented in a way not to my liking.
> 
> I reviewed these patches when they arrived, and I got a poor opinion
> of them.  However, I decided to give the patches a chance, and wait
> and see what feedback/code-review they got.  So far they have received
> nothing.

That's not a good way to do review comments.  If you review them, let
the author know about your poor opinion.  That gives them, and others,
the chance to change your opinion if others feel you are incorrect, or,
if you are correct, it lets the author know they need to change their
code.

Just doing nothing publically doesn't help anyone out here, and only
causes confusion as this thread shows.

I read over these patches a while ago and offered some review, which I
see has been taken into consideration and changes were made.  Please let
us know your opinion so that we can all get something that works for
everyone accepted here.

thanks,

greg k-h