From: Peter Korsgaard <jacmet@sunsite.dk>
To: Phillip Lougher <phillip.lougher@gmail.com>
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>,
richard -rw- weinberger <richard.weinberger@gmail.com>,
linux-fsdevel@vger.kernel.org, Vyacheslav.Dubeyko@huawei.com,
squashfs-devel@lists.sourceforge.net
Subject: Re: [Squashfs-devel] [squashfs] Who is responsible for code review?
Date: Sat, 23 Jun 2012 14:24:27 +0200 [thread overview]
Message-ID: <87oboacj2c.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <CAB3wodfkoXqqvCj-mTMeaMrt1fTs2-+kTNpnkjj=bzpj+4_f+Q@mail.gmail.com> (Phillip Lougher's message of "Sat, 23 Jun 2012 03:01:27 +0100")
>>>>> "Phillip" == Phillip Lougher <phillip.lougher@gmail.com> writes:
Hi,
Phillip> The patches in question are adding a new feature to Squashfs.
Phillip> New features are always nice to have, but always carry the
Phillip> risk of introducing bugs, performance regressions, and
Phillip> generally making the code harder to maintain if (as is the
Phillip> case with these patches) they have been implemented in a way
Phillip> not to my liking.
Phillip> I reviewed these patches when they arrived, and I got a poor
Phillip> opinion of them. However, I decided to give the patches a
Phillip> chance, and wait and see what feedback/code-review they got.
Phillip> So far they have received nothing.
I would also prefer to see direct mtd support instead of through
mtdblock if anything rather than this direct memory access.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-06-23 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 7:15 [squashfs] Who is responsible for code review? Vyacheslav Dubeyko
2012-06-22 10:30 ` richard -rw- weinberger
2012-06-22 10:53 ` Vyacheslav Dubeyko
2012-06-23 2:01 ` Phillip Lougher
2012-06-23 2:52 ` Greg KH
2012-06-23 12:24 ` Peter Korsgaard [this message]
2012-06-23 0:25 ` Phillip Lougher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oboacj2c.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=Vyacheslav.Dubeyko@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=phillip.lougher@gmail.com \
--cc=richard.weinberger@gmail.com \
--cc=slava@dubeyko.com \
--cc=squashfs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.