From: Johannes Weiner <hannes@cmpxchg.org>
To: Wanpeng Li <liwp.linux@gmail.com>
Cc: linux-mm@kvack.org, Michal Hocko <mhocko@suse.cz>,
Balbir Singh <bsingharora@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>, Minchan Kim <minchan@kernel.org>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/6] memcg: replace unsigned long by u64 to avoid overflow
Date: Sat, 23 Jun 2012 11:26:54 +0200 [thread overview]
Message-ID: <20120623092654.GL27816@cmpxchg.org> (raw)
In-Reply-To: <20120623090339.GA6184@kernel>
On Sat, Jun 23, 2012 at 05:03:39PM +0800, Wanpeng Li wrote:
> On Sat, Jun 23, 2012 at 10:15:14AM +0200, Johannes Weiner wrote:
> >On Sat, Jun 23, 2012 at 02:15:34PM +0800, Wanpeng Li wrote:
> >> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
> >>
> >> Since the return value variable in mem_cgroup_zone_nr_lru_pages and
> >> mem_cgroup_node_nr_lru_pages functions are u64, so replace the return
> >> value of funtions by u64 to avoid overflow.
> >
> >I wonder what 16 TB of memory must think running on a 32-bit kernel...
> >"What is this, an address space for ants?"
>
> Hi Johannes,
>
> You mean change all u64 in memcg to unsigned long? or something I
> miss....
Not _all_ of them, we have some that count bytes. But those counting
pages should probably be ulong, yes.
I think Kame added the ones that you wanted to adjust the surroundings
for in particular, so let's ask him. Kame?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Wanpeng Li <liwp.linux@gmail.com>
Cc: linux-mm@kvack.org, Michal Hocko <mhocko@suse.cz>,
Balbir Singh <bsingharora@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>, Minchan Kim <minchan@kernel.org>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/6] memcg: replace unsigned long by u64 to avoid overflow
Date: Sat, 23 Jun 2012 11:26:54 +0200 [thread overview]
Message-ID: <20120623092654.GL27816@cmpxchg.org> (raw)
In-Reply-To: <20120623090339.GA6184@kernel>
On Sat, Jun 23, 2012 at 05:03:39PM +0800, Wanpeng Li wrote:
> On Sat, Jun 23, 2012 at 10:15:14AM +0200, Johannes Weiner wrote:
> >On Sat, Jun 23, 2012 at 02:15:34PM +0800, Wanpeng Li wrote:
> >> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
> >>
> >> Since the return value variable in mem_cgroup_zone_nr_lru_pages and
> >> mem_cgroup_node_nr_lru_pages functions are u64, so replace the return
> >> value of funtions by u64 to avoid overflow.
> >
> >I wonder what 16 TB of memory must think running on a 32-bit kernel...
> >"What is this, an address space for ants?"
>
> Hi Johannes,
>
> You mean change all u64 in memcg to unsigned long? or something I
> miss....
Not _all_ of them, we have some that count bytes. But those counting
pages should probably be ulong, yes.
I think Kame added the ones that you wanted to adjust the surroundings
for in particular, so let's ask him. Kame?
next prev parent reply other threads:[~2012-06-23 9:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-23 6:15 [PATCH 1/6] memcg: replace unsigned long by u64 to avoid overflow Wanpeng Li
2012-06-23 6:15 ` Wanpeng Li
2012-06-23 6:15 ` Wanpeng Li
2012-06-23 8:15 ` Johannes Weiner
2012-06-23 8:15 ` Johannes Weiner
2012-06-23 9:03 ` Wanpeng Li
2012-06-23 9:03 ` Wanpeng Li
2012-06-23 9:26 ` Johannes Weiner [this message]
2012-06-23 9:26 ` Johannes Weiner
2012-06-25 4:24 ` Kamezawa Hiroyuki
2012-06-25 4:24 ` Kamezawa Hiroyuki
[not found] ` <4FE7E7FA.80702-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-06-25 4:46 ` Wanpeng Li
2012-06-25 4:46 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120623092654.GL27816@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwp.linux@gmail.com \
--cc=mel@csn.ul.ie \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.