From: Tejun Heo <tj@kernel.org>
To: Glauber Costa <glommer@parallels.com>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
David Rientjes <rientjes@google.com>,
Pekka Enberg <penberg@kernel.org>, Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Christoph Lameter <cl@linux.com>,
devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com,
Pekka Enberg <penberg@cs.helsinki.fi>,
Suleiman Souhlal <suleiman@google.com>
Subject: Re: [PATCH 07/11] mm: Allocate kernel pages to the right memcg
Date: Mon, 25 Jun 2012 11:07:47 -0700 [thread overview]
Message-ID: <20120625180747.GE3869@google.com> (raw)
In-Reply-To: <1340633728-12785-8-git-send-email-glommer@parallels.com>
On Mon, Jun 25, 2012 at 06:15:24PM +0400, Glauber Costa wrote:
> When a process tries to allocate a page with the __GFP_KMEMCG flag,
> the page allocator will call the corresponding memcg functions to
> validate the allocation. Tasks in the root memcg can always proceed.
>
> To avoid adding markers to the page - and a kmem flag that would
> necessarily follow, as much as doing page_cgroup lookups for no
> reason, whoever is marking its allocations with __GFP_KMEMCG flag
> is responsible for telling the page allocator that this is such an
> allocation at free_pages() time. This is done by the invocation of
> __free_accounted_pages() and free_accounted_pages().
Shouldn't we be documenting that in the code somewhere, preferably in
the function comments?
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Glauber Costa <glommer@parallels.com>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
David Rientjes <rientjes@google.com>,
Pekka Enberg <penberg@kernel.org>, Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Christoph Lameter <cl@linux.com>,
devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com,
Pekka Enberg <penberg@cs.helsinki.fi>,
Suleiman Souhlal <suleiman@google.com>
Subject: Re: [PATCH 07/11] mm: Allocate kernel pages to the right memcg
Date: Mon, 25 Jun 2012 11:07:47 -0700 [thread overview]
Message-ID: <20120625180747.GE3869@google.com> (raw)
In-Reply-To: <1340633728-12785-8-git-send-email-glommer@parallels.com>
On Mon, Jun 25, 2012 at 06:15:24PM +0400, Glauber Costa wrote:
> When a process tries to allocate a page with the __GFP_KMEMCG flag,
> the page allocator will call the corresponding memcg functions to
> validate the allocation. Tasks in the root memcg can always proceed.
>
> To avoid adding markers to the page - and a kmem flag that would
> necessarily follow, as much as doing page_cgroup lookups for no
> reason, whoever is marking its allocations with __GFP_KMEMCG flag
> is responsible for telling the page allocator that this is such an
> allocation at free_pages() time. This is done by the invocation of
> __free_accounted_pages() and free_accounted_pages().
Shouldn't we be documenting that in the code somewhere, preferably in
the function comments?
--
tejun
next prev parent reply other threads:[~2012-06-25 18:07 UTC|newest]
Thread overview: 238+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 14:15 [PATCH 00/11] kmem controller for memcg: stripped down version Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 01/11] memcg: Make it possible to use the stock for more than one page Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
[not found] ` <1340633728-12785-2-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-25 17:44 ` Tejun Heo
2012-06-25 17:44 ` Tejun Heo
2012-06-25 17:44 ` Tejun Heo
2012-06-25 22:29 ` Glauber Costa
2012-06-25 22:29 ` Glauber Costa
2012-06-25 22:33 ` Tejun Heo
2012-06-25 22:33 ` Tejun Heo
2012-06-26 4:01 ` David Rientjes
2012-06-26 4:01 ` David Rientjes
2012-06-25 14:15 ` [PATCH 02/11] memcg: Reclaim when more than one page needed Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 23:33 ` Suleiman Souhlal
2012-06-25 23:33 ` Suleiman Souhlal
2012-06-26 8:39 ` Glauber Costa
2012-06-26 8:39 ` Glauber Costa
[not found] ` <4FE9755B.1040905-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-27 16:16 ` Suleiman Souhlal
2012-06-27 16:16 ` Suleiman Souhlal
2012-06-27 16:16 ` Suleiman Souhlal
2012-06-26 4:09 ` David Rientjes
2012-06-26 4:09 ` David Rientjes
[not found] ` <alpine.DEB.2.00.1206252106430.26640-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-06-26 7:12 ` Glauber Costa
2012-06-26 7:12 ` Glauber Costa
2012-06-26 7:12 ` Glauber Costa
[not found] ` <4FE960D6.4040409-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-26 8:54 ` David Rientjes
2012-06-26 8:54 ` David Rientjes
2012-06-26 8:54 ` David Rientjes
2012-06-26 9:08 ` Glauber Costa
2012-06-26 9:08 ` Glauber Costa
2012-06-26 9:17 ` David Rientjes
2012-06-26 9:17 ` David Rientjes
2012-06-26 9:23 ` Glauber Costa
2012-06-26 9:23 ` Glauber Costa
2012-06-27 10:03 ` Glauber Costa
2012-06-27 10:03 ` Glauber Costa
[not found] ` <4FEADA55.4060409-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-27 19:48 ` David Rientjes
2012-06-27 19:48 ` David Rientjes
2012-06-27 19:48 ` David Rientjes
2012-06-27 20:47 ` Glauber Costa
2012-06-27 20:47 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 03/11] memcg: change defines to an enum Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-26 4:11 ` David Rientjes
2012-06-26 4:11 ` David Rientjes
2012-06-26 8:28 ` Glauber Costa
2012-06-26 8:28 ` Glauber Costa
[not found] ` <4FE972B2.1020509-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-26 9:01 ` David Rientjes
2012-06-26 9:01 ` David Rientjes
2012-06-26 9:01 ` David Rientjes
2012-06-25 14:15 ` [PATCH 04/11] kmem slab accounting basic infrastructure Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-26 4:22 ` David Rientjes
2012-06-26 4:22 ` David Rientjes
2012-06-26 7:09 ` Glauber Costa
2012-06-26 7:09 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 05/11] Add a __GFP_KMEMCG flag Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-26 4:25 ` David Rientjes
2012-06-26 4:25 ` David Rientjes
2012-06-26 7:08 ` Glauber Costa
2012-06-26 7:08 ` Glauber Costa
2012-06-26 9:03 ` David Rientjes
2012-06-26 9:03 ` David Rientjes
2012-06-25 14:15 ` [PATCH 06/11] memcg: kmem controller infrastructure Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
[not found] ` <1340633728-12785-7-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-25 18:06 ` Tejun Heo
2012-06-25 18:06 ` Tejun Heo
2012-06-25 18:06 ` Tejun Heo
2012-06-25 22:28 ` Glauber Costa
2012-06-25 22:28 ` Glauber Costa
2012-06-25 23:17 ` Andrew Morton
2012-06-25 23:17 ` Andrew Morton
2012-06-25 23:17 ` Andrew Morton
2012-06-26 14:40 ` Glauber Costa
2012-06-26 14:40 ` Glauber Costa
[not found] ` <20120625161720.ae13ae90.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-06-26 15:01 ` Glauber Costa
2012-06-26 15:01 ` Glauber Costa
2012-06-26 15:01 ` Glauber Costa
[not found] ` <4FE9CEBB.80108-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-26 18:01 ` Andrew Morton
2012-06-26 18:01 ` Andrew Morton
2012-06-26 18:01 ` Andrew Morton
[not found] ` <20120626110142.b7cf6d7c.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-06-26 18:08 ` Tejun Heo
2012-06-26 18:08 ` Tejun Heo
2012-06-26 18:08 ` Tejun Heo
2012-06-26 18:14 ` Glauber Costa
2012-06-26 18:14 ` Glauber Costa
2012-06-26 19:20 ` Andrew Morton
2012-06-26 19:20 ` Andrew Morton
2012-06-26 15:29 ` Glauber Costa
2012-06-26 15:29 ` Glauber Costa
2012-06-26 15:29 ` Glauber Costa
2012-06-26 9:12 ` David Rientjes
2012-06-26 9:12 ` David Rientjes
2012-06-26 9:12 ` David Rientjes
[not found] ` <alpine.DEB.2.00.1206260210200.16020-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-06-26 9:17 ` Glauber Costa
2012-06-26 9:17 ` Glauber Costa
2012-06-26 9:17 ` Glauber Costa
2012-06-27 4:01 ` David Rientjes
2012-06-27 4:01 ` David Rientjes
[not found] ` <alpine.DEB.2.00.1206262100320.24245-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-06-27 9:33 ` Glauber Costa
2012-06-27 9:33 ` Glauber Costa
2012-06-27 9:33 ` Glauber Costa
2012-06-27 19:46 ` David Rientjes
2012-06-27 19:46 ` David Rientjes
2012-06-25 14:15 ` [PATCH 07/11] mm: Allocate kernel pages to the right memcg Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 18:07 ` Tejun Heo [this message]
2012-06-25 18:07 ` Tejun Heo
2012-06-25 22:27 ` Glauber Costa
2012-06-25 22:27 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 08/11] memcg: disable kmem code when not in use Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-26 5:51 ` Kamezawa Hiroyuki
2012-06-26 5:51 ` Kamezawa Hiroyuki
2012-06-25 14:15 ` [PATCH 09/11] memcg: propagate kmem limiting information to children Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 18:29 ` Tejun Heo
2012-06-25 18:29 ` Tejun Heo
[not found] ` <20120625182907.GF3869-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-06-25 22:36 ` Glauber Costa
2012-06-25 22:36 ` Glauber Costa
2012-06-25 22:36 ` Glauber Costa
[not found] ` <4FE8E7EB.2020804-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-25 22:49 ` Tejun Heo
2012-06-25 22:49 ` Tejun Heo
2012-06-25 22:49 ` Tejun Heo
2012-06-25 23:21 ` Andrew Morton
2012-06-25 23:21 ` Andrew Morton
2012-06-26 5:23 ` David Rientjes
2012-06-26 5:23 ` David Rientjes
2012-06-25 23:23 ` Andrew Morton
2012-06-25 23:23 ` Andrew Morton
2012-06-26 5:24 ` David Rientjes
2012-06-26 5:24 ` David Rientjes
[not found] ` <alpine.DEB.2.00.1206252224350.30072-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-06-26 5:31 ` Andrew Morton
2012-06-26 5:31 ` Andrew Morton
2012-06-26 5:31 ` Andrew Morton
[not found] ` <20120625223136.86ebee05.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-06-26 7:23 ` Glauber Costa
2012-06-26 7:23 ` Glauber Costa
2012-06-26 7:23 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 10/11] memcg: allow a memcg with kmem charges to be destructed Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 18:34 ` Tejun Heo
2012-06-25 18:34 ` Tejun Heo
[not found] ` <20120625183442.GG3869-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-06-25 22:25 ` Glauber Costa
2012-06-25 22:25 ` Glauber Costa
2012-06-25 22:25 ` Glauber Costa
2012-06-26 5:59 ` Kamezawa Hiroyuki
2012-06-26 5:59 ` Kamezawa Hiroyuki
[not found] ` <4FE94FDC.7070105-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-06-26 7:21 ` Glauber Costa
2012-06-26 7:21 ` Glauber Costa
2012-06-26 7:21 ` Glauber Costa
2012-06-25 14:15 ` [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 14:15 ` Glauber Costa
2012-06-25 16:55 ` Frederic Weisbecker
2012-06-25 16:55 ` Frederic Weisbecker
[not found] ` <4FE89807.50708-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-06-25 18:38 ` Tejun Heo
2012-06-25 18:38 ` Tejun Heo
2012-06-25 18:38 ` Tejun Heo
[not found] ` <20120625183818.GH3869-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-06-25 20:57 ` Frederic Weisbecker
2012-06-25 20:57 ` Frederic Weisbecker
2012-06-25 20:57 ` Frederic Weisbecker
2012-06-26 12:48 ` Glauber Costa
2012-06-26 12:48 ` Glauber Costa
2012-06-26 12:48 ` Glauber Costa
[not found] ` <4FE9AF88.5070803-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-26 13:38 ` Frederic Weisbecker
2012-06-26 13:38 ` Frederic Weisbecker
2012-06-26 13:38 ` Frederic Weisbecker
[not found] ` <20120626133838.GA11519-oHC15RC7JGTpAmv0O++HtFaTQe2KTcn/@public.gmane.org>
2012-06-26 13:37 ` Glauber Costa
2012-06-26 13:37 ` Glauber Costa
2012-06-26 13:37 ` Glauber Costa
[not found] ` <4FE9BB25.60905-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-26 13:44 ` Frederic Weisbecker
2012-06-26 13:44 ` Frederic Weisbecker
2012-06-26 13:44 ` Frederic Weisbecker
2012-06-26 4:57 ` David Rientjes
2012-06-26 4:57 ` David Rientjes
[not found] ` <alpine.DEB.2.00.1206252157000.30072-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-06-26 5:35 ` Kamezawa Hiroyuki
2012-06-26 5:35 ` Kamezawa Hiroyuki
2012-06-26 5:35 ` Kamezawa Hiroyuki
2012-06-26 7:23 ` Glauber Costa
2012-06-26 7:23 ` Glauber Costa
2012-06-26 7:23 ` Glauber Costa
[not found] ` <4FE96358.6080601-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-26 8:45 ` David Rientjes
2012-06-26 8:45 ` David Rientjes
2012-06-26 8:45 ` David Rientjes
[not found] ` <alpine.DEB.2.00.1206260143450.16020-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-06-26 8:44 ` Glauber Costa
2012-06-26 8:44 ` Glauber Costa
2012-06-26 8:44 ` Glauber Costa
2012-06-26 9:05 ` David Rientjes
2012-06-26 9:05 ` David Rientjes
2012-06-25 23:27 ` [PATCH 00/11] kmem controller for memcg: stripped down version Andrew Morton
2012-06-25 23:27 ` Andrew Morton
2012-06-26 7:17 ` Glauber Costa
2012-06-26 7:17 ` Glauber Costa
[not found] ` <4FE9621D.2050002-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-26 21:55 ` Andrew Morton
2012-06-26 21:55 ` Andrew Morton
2012-06-26 21:55 ` Andrew Morton
2012-06-27 1:08 ` David Rientjes
2012-06-27 1:08 ` David Rientjes
[not found] ` <alpine.DEB.2.00.1206261804160.11287-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-06-27 8:39 ` Glauber Costa
2012-06-27 8:39 ` Glauber Costa
2012-06-27 8:39 ` Glauber Costa
[not found] ` <20120626145539.eeeab909.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-06-27 9:29 ` Fork bomb limitation in memcg WAS: " Glauber Costa
2012-06-27 9:29 ` Glauber Costa
2012-06-27 9:29 ` Glauber Costa
2012-06-27 12:29 ` Frederic Weisbecker
2012-06-27 12:29 ` Frederic Weisbecker
2012-06-27 12:28 ` Glauber Costa
2012-06-27 12:28 ` Glauber Costa
2012-06-27 12:35 ` Frederic Weisbecker
2012-06-27 12:35 ` Frederic Weisbecker
[not found] ` <4FEAD260.4000603-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-27 19:38 ` David Rientjes
2012-06-27 19:38 ` David Rientjes
2012-06-27 19:38 ` David Rientjes
2012-06-28 9:01 ` Glauber Costa
2012-06-28 9:01 ` Glauber Costa
2012-06-28 22:25 ` Andrew Morton
2012-06-28 22:25 ` Andrew Morton
[not found] ` <20120628152540.cc13a735.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-07-03 11:38 ` Glauber Costa
2012-07-03 11:38 ` Glauber Costa
2012-07-03 11:38 ` Glauber Costa
2012-07-12 15:40 ` Frederic Weisbecker
2012-07-12 15:40 ` Frederic Weisbecker
2012-08-07 13:59 ` Glauber Costa
2012-08-07 13:59 ` Glauber Costa
2012-08-07 13:59 ` Glauber Costa
[not found] ` <50211F3D.2000008-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-08-08 14:15 ` Glauber Costa
2012-08-08 14:15 ` Glauber Costa
2012-08-08 14:15 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120625180747.GE3869@google.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=devel@openvz.org \
--cc=fweisbec@gmail.com \
--cc=glommer@parallels.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=suleiman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.