From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Hebbar, Gururaja" <gururaja.hebbar@ti.com>
Cc: alsa-devel@alsa-project.org, sudhakar.raj@ti.com, nsekhar@ti.com,
davinci-linux-open-source@linux.davincidsp.com,
alsa-user@lists.sourceforge.net, lrg@ti.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2] ASoC: tlv320aic3x: Fix codec pll configure bug
Date: Tue, 26 Jun 2012 09:54:03 +0100 [thread overview]
Message-ID: <20120626085403.GH30406@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1340690623-18177-1-git-send-email-gururaja.hebbar@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 619 bytes --]
On Tue, Jun 26, 2012 at 11:33:43AM +0530, Hebbar, Gururaja wrote:
> In sound/soc/codecs/tlv320aic3x.c
>
> data = snd_soc_read(codec, AIC3X_PLL_PROGA_REG);
> snd_soc_write(codec, AIC3X_PLL_PROGA_REG,
> data | (pll_p << PLLP_SHIFT));
>
> In the above code, pll-p value is OR'ed with previous value without
> clearing it. Bug is not seen if pll-p value doesn't change across
> Sampling frequency.
A better fix is to change the code to use snd_soc_update_bits() rather
than open code it. This is more idiomatic and will suppress writes if
they don't change anything.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] ASoC: tlv320aic3x: Fix codec pll configure bug
Date: Tue, 26 Jun 2012 09:54:03 +0100 [thread overview]
Message-ID: <20120626085403.GH30406@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1340690623-18177-1-git-send-email-gururaja.hebbar@ti.com>
On Tue, Jun 26, 2012 at 11:33:43AM +0530, Hebbar, Gururaja wrote:
> In sound/soc/codecs/tlv320aic3x.c
>
> data = snd_soc_read(codec, AIC3X_PLL_PROGA_REG);
> snd_soc_write(codec, AIC3X_PLL_PROGA_REG,
> data | (pll_p << PLLP_SHIFT));
>
> In the above code, pll-p value is OR'ed with previous value without
> clearing it. Bug is not seen if pll-p value doesn't change across
> Sampling frequency.
A better fix is to change the code to use snd_soc_update_bits() rather
than open code it. This is more idiomatic and will suppress writes if
they don't change anything.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120626/ebaf029c/attachment.sig>
next prev parent reply other threads:[~2012-06-26 8:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 6:03 [PATCH V2] ASoC: tlv320aic3x: Fix codec pll configure bug Hebbar, Gururaja
2012-06-26 6:03 ` Hebbar, Gururaja
2012-06-26 8:54 ` Mark Brown [this message]
2012-06-26 8:54 ` Mark Brown
2012-06-26 14:07 ` Hebbar, Gururaja
2012-06-26 14:07 ` Hebbar, Gururaja
2012-06-26 9:01 ` Prchal Jiří
2012-06-26 9:01 ` Prchal Jiří
2012-06-26 14:08 ` Hebbar, Gururaja
2012-06-26 14:08 ` Hebbar, Gururaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626085403.GH30406@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=alsa-user@lists.sourceforge.net \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=gururaja.hebbar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@ti.com \
--cc=nsekhar@ti.com \
--cc=sudhakar.raj@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.