From: "J. Bruce Fields" <bfields@fieldses.org>
To: Filipe Brandenburger <filbranden@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Matthew Wilcox <matthew@wil.cx>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] locks: prevent side-effects of locks_release_private before file_lock is initialized
Date: Tue, 26 Jun 2012 11:23:37 -0400 [thread overview]
Message-ID: <20120626152336.GD14279@fieldses.org> (raw)
In-Reply-To: <CABe66sXc6tD83D=w_=YeNBo-5A7Q_KPTCq1-Dfnk9JCNw0i5ug@mail.gmail.com>
On Mon, Jun 25, 2012 at 10:10:35PM -0400, Filipe Brandenburger wrote:
> Just to let you know that I just tested the patch below on top of
> 3.5.0-rc4 and it works fine...
>
> Do you like the idea of this second patch or do you prefer the
> __locks_free_lock() one?
Like I said:
> Let's just go with your first patch and free the thing by hand (but
> add a comment explaining why).
>
> Then come back and figure out how to make the interface clearer once
> we've got the bug fixed.
--b.
next prev parent reply other threads:[~2012-06-26 15:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-16 3:06 [PATCH 0/1] locks: prevent side-effects of locks_release_private before file_lock is initialized Filipe Brandenburger
2012-06-16 3:06 ` [PATCH 1/1] " Filipe Brandenburger
2012-06-18 20:01 ` J. Bruce Fields
2012-06-20 2:39 ` Filipe Brandenburger
2012-06-26 0:29 ` J. Bruce Fields
2012-06-26 0:48 ` Filipe Brandenburger
2012-06-26 2:10 ` Filipe Brandenburger
2012-06-26 2:10 ` Filipe Brandenburger
2012-06-26 15:23 ` J. Bruce Fields [this message]
2012-06-27 1:50 ` [PATCH v2 " Filipe Brandenburger
2012-07-05 22:42 ` J. Bruce Fields
2012-07-07 19:04 ` J. Bruce Fields
2012-07-27 4:42 ` [PATCHv3] " Filipe Brandenburger
2012-07-27 20:45 ` J. Bruce Fields
2012-07-29 15:56 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626152336.GD14279@fieldses.org \
--to=bfields@fieldses.org \
--cc=filbranden@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.