From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
Peter Zijlstra
<a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
Kamezawa Hiroyuki
<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] memcg: first step towards hierarchical controller
Date: Tue, 26 Jun 2012 17:37:19 +0200 [thread overview]
Message-ID: <20120626153719.GC27816@cmpxchg.org> (raw)
In-Reply-To: <4FE9D5C9.805-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
On Tue, Jun 26, 2012 at 07:31:21PM +0400, Glauber Costa wrote:
> On 06/26/2012 06:11 PM, Johannes Weiner wrote:
> >I find the warning message a bit terse. Maybe include something like
> >"restructure the cgroup directory structure to match your accounting
> >requirements or complain to (linux-mm, cgroups list etc.) if not
> >possible"
>
> How about:
>
> WARN_ONCE(!parent_memcg && memcg->use_hierarchy,
> "Non-hierarchical memcg is considered for deprecation\n"
> "Please consider reorganizing your tree to work with hierarchical
> accounting\n"
> "If you have any reason not to, let us know at
> cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n");
Sounds good to me, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Glauber Costa <glommer@parallels.com>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michal Hocko <mhocko@suse.cz>,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] memcg: first step towards hierarchical controller
Date: Tue, 26 Jun 2012 17:37:19 +0200 [thread overview]
Message-ID: <20120626153719.GC27816@cmpxchg.org> (raw)
In-Reply-To: <4FE9D5C9.805@parallels.com>
On Tue, Jun 26, 2012 at 07:31:21PM +0400, Glauber Costa wrote:
> On 06/26/2012 06:11 PM, Johannes Weiner wrote:
> >I find the warning message a bit terse. Maybe include something like
> >"restructure the cgroup directory structure to match your accounting
> >requirements or complain to (linux-mm, cgroups list etc.) if not
> >possible"
>
> How about:
>
> WARN_ONCE(!parent_memcg && memcg->use_hierarchy,
> "Non-hierarchical memcg is considered for deprecation\n"
> "Please consider reorganizing your tree to work with hierarchical
> accounting\n"
> "If you have any reason not to, let us know at
> cgroups@vger.kernel.org\n");
Sounds good to me, thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-26 15:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 13:30 [PATCH] memcg: first step towards hierarchical controller Glauber Costa
2012-06-26 13:30 ` Glauber Costa
[not found] ` <1340717428-9009-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-26 14:11 ` Johannes Weiner
2012-06-26 14:11 ` Johannes Weiner
2012-06-26 14:19 ` Peter Zijlstra
2012-06-26 14:38 ` Johannes Weiner
2012-06-26 14:38 ` Glauber Costa
[not found] ` <20120626143818.GB27816-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2012-06-26 14:41 ` Peter Zijlstra
2012-06-26 14:41 ` Peter Zijlstra
2012-06-26 14:29 ` Glauber Costa
[not found] ` <20120626141127.GA27816-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2012-06-26 15:31 ` Glauber Costa
2012-06-26 15:31 ` Glauber Costa
[not found] ` <4FE9D5C9.805-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-26 15:37 ` Johannes Weiner [this message]
2012-06-26 15:37 ` Johannes Weiner
2012-06-26 15:27 ` Michal Hocko
2012-06-26 15:27 ` Michal Hocko
[not found] ` <20120626152711.GF9566-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-06-26 15:28 ` Glauber Costa
2012-06-26 15:28 ` Glauber Costa
[not found] ` <4FE9D501.3050004-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-26 15:50 ` Michal Hocko
2012-06-26 15:50 ` Michal Hocko
2012-06-26 18:12 ` Tejun Heo
2012-06-26 18:12 ` Tejun Heo
[not found] ` <20120626181209.GR3869-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-06-26 18:22 ` Glauber Costa
2012-06-26 18:22 ` Glauber Costa
[not found] ` <4FE9FDCC.80000-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-06-26 18:32 ` Tejun Heo
2012-06-26 18:32 ` Tejun Heo
2012-06-26 22:12 ` Michal Hocko
2012-06-26 22:12 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626153719.GC27816@cmpxchg.org \
--to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
--cc=a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.