From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 3/5] batman-adv: enable roaming packets to carry flags
Date: Wed, 27 Jun 2012 08:31:36 +0200 [thread overview]
Message-ID: <20120627063136.GD3290@ritirata.org> (raw)
In-Reply-To: <4FEA2D81.5030407@universe-factory.net>
[-- Attachment #1: Type: text/plain, Size: 2220 bytes --]
On Tue, Jun 26, 2012 at 11:45:37PM +0200, Matthias Schiffer wrote:
> On 06/26/2012 11:22 PM, Sven Eckelmann wrote:
> > On Tuesday 26 June 2012 22:00:20 Antonio Quartulli wrote:
> >> In case of client-roaming it would be useful to carry TT flags along with
> >> the client entry. Information contained in the flags could be used on the
> >> new mesh node for several reasons (e.g. particular roaming treatment).
> >>
> >> This patch modifies the ROAMING_ADV packet according to this idea so that it
> >> can also carry the flags together with the MAC address of the moving
> >> client.
> >>
> >> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> >> ---
> >> packet.h | 2 +-
> >> routing.c | 7 ++++---
> >> translation-table.c | 17 ++++++++++-------
> >> 3 files changed, 15 insertions(+), 11 deletions(-)
> >>
> >> diff --git a/packet.h b/packet.h
> >> index 65d66e4..e0b94a3 100644
> >> --- a/packet.h
> >> +++ b/packet.h
> >> @@ -214,7 +214,7 @@ struct batadv_tt_query_packet {
> >>
> >> struct batadv_roam_adv_packet {
> >> struct batadv_header header;
> >> - uint8_t reserved;
> >> + uint8_t flags;
> >> uint8_t dst[ETH_ALEN];
> >> uint8_t src[ETH_ALEN];
> >> uint8_t client[ETH_ALEN];
> >
> > I am not 100% sure because I haven't checked the code, but couldn't it be the
> > case that we send random bits inside reserved at the moment? At least I cannot
> > remember the part of the code that initialized reserver to any specific value.
> > That would make the change incompatible with older batman-adv version.
>
> As stated in an earlier mail, the `reserved' field in the vis packets
> isn't initialized either, leading to the same problem, being unable to
> ever use this field for anything when you want to stay compatible with
> older versions.
>
> IMO this should be fixed in all packets, it's a really bad idea to send
> uninitialized memory over the network...
Yes, I agree. we have to remember this fix the next time we decide to break
compatibility. I don't think we are going to do it now.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-06-27 6:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 20:00 [B.A.T.M.A.N.] [PATCH 0/5] new feature: Speedy Join 2012-06-26 Antonio Quartulli
2012-06-26 20:00 ` [B.A.T.M.A.N.] [PATCH 1/5] batman-adv: add reference counting for type batadv_tt_orig_list_entry Antonio Quartulli
2012-06-26 21:23 ` Sven Eckelmann
[not found] ` <3809123.2JX82ntKN2@sven-laptop.home.narfation.org>
2012-06-27 6:26 ` Antonio Quartulli
[not found] ` <1403237.H233GFHdJC@sven-laptop.home.narfation.org>
2012-06-27 6:26 ` Antonio Quartulli
2012-06-26 20:00 ` [B.A.T.M.A.N.] [PATCH 2/5] batman-adv: implement batadv_tt_global_entry_get_orig() Antonio Quartulli
2012-06-26 20:00 ` [B.A.T.M.A.N.] [PATCH 3/5] batman-adv: enable roaming packets to carry flags Antonio Quartulli
2012-06-26 21:22 ` Sven Eckelmann
2012-06-26 21:45 ` Matthias Schiffer
2012-06-27 6:31 ` Antonio Quartulli [this message]
[not found] ` <3265215.erIRmWtS44@sven-laptop.home.narfation.org>
2012-06-27 6:30 ` Antonio Quartulli
2012-06-27 6:58 ` Antonio Quartulli
2012-06-26 20:00 ` [B.A.T.M.A.N.] [PATCH 4/5] batman-adv: detect not yet announced clients Antonio Quartulli
2012-06-26 21:50 ` Sven Eckelmann
2012-06-27 6:34 ` Antonio Quartulli
2012-06-26 20:00 ` [B.A.T.M.A.N.] [PATCH 5/5] batman-adv: change interface_rx to get orig node Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627063136.GD3290@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.