All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <ordex@autistici.org>
To: Sven Eckelmann <sven@narfation.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 3/5] batman-adv: enable roaming packets to carry flags
Date: Wed, 27 Jun 2012 08:58:19 +0200	[thread overview]
Message-ID: <20120627065818.GF3290@ritirata.org> (raw)
In-Reply-To: <20120627063021.GC3290@ritirata.org>

[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]

On Wed, Jun 27, 2012 at 08:30:22AM +0200, Antonio Quartulli wrote:
> On Tue, Jun 26, 2012 at 11:18:29PM +0200, Sven Eckelmann wrote:
> >    I am not 100% sure because I haven't checked the code, but couldn't it be
> >    the case that we send random bits inside reserved at the moment? At least
> >    I cannot remember the part of the code that initialized reserver to any
> >    specific value. That would make the change incompatible with older
> >    batman-adv version.
> 
> Damn, that's true! It is not initialised anywhere....
> What if I append a new field to the roam_adv_packet struct? Old version will
> ignore it and there is no size check to drop packets longer than expected.

Ok, after discussing with Sven on irc I got to the point that it is simply
better to skip this patch. Appending a new field would make the new code much
more complicated (and ugly) because we have to consider that we could receive
old packets with a smaller size (and they should not be dropped).

I think that the best solution is to remove this patch.

The idea in this code
was to send the new TT_CLIENT_TEMP flag within the roam_adv so that the receiver
node can eventually purge this entry if not claimed anymore. However this is not
needed because a roaming client is already marked as ROAM on the receiver side and
so it will already be purged if not claimed within a fixed amount of time.

Cheers,


-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2012-06-27  6:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26 20:00 [B.A.T.M.A.N.] [PATCH 0/5] new feature: Speedy Join 2012-06-26 Antonio Quartulli
2012-06-26 20:00 ` [B.A.T.M.A.N.] [PATCH 1/5] batman-adv: add reference counting for type batadv_tt_orig_list_entry Antonio Quartulli
2012-06-26 21:23   ` Sven Eckelmann
     [not found]   ` <3809123.2JX82ntKN2@sven-laptop.home.narfation.org>
2012-06-27  6:26     ` Antonio Quartulli
     [not found]   ` <1403237.H233GFHdJC@sven-laptop.home.narfation.org>
2012-06-27  6:26     ` Antonio Quartulli
2012-06-26 20:00 ` [B.A.T.M.A.N.] [PATCH 2/5] batman-adv: implement batadv_tt_global_entry_get_orig() Antonio Quartulli
2012-06-26 20:00 ` [B.A.T.M.A.N.] [PATCH 3/5] batman-adv: enable roaming packets to carry flags Antonio Quartulli
2012-06-26 21:22   ` Sven Eckelmann
2012-06-26 21:45     ` Matthias Schiffer
2012-06-27  6:31       ` Antonio Quartulli
     [not found]   ` <3265215.erIRmWtS44@sven-laptop.home.narfation.org>
2012-06-27  6:30     ` Antonio Quartulli
2012-06-27  6:58       ` Antonio Quartulli [this message]
2012-06-26 20:00 ` [B.A.T.M.A.N.] [PATCH 4/5] batman-adv: detect not yet announced clients Antonio Quartulli
2012-06-26 21:50   ` Sven Eckelmann
2012-06-27  6:34     ` Antonio Quartulli
2012-06-26 20:00 ` [B.A.T.M.A.N.] [PATCH 5/5] batman-adv: change interface_rx to get orig node Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120627065818.GF3290@ritirata.org \
    --to=ordex@autistici.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.