All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch -next] 6lowpan: double unlock on an error path
@ 2012-06-27  6:53 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2012-06-27  6:53 UTC (permalink / raw)
  To: Dmitry Eremin-Solenikov
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
	linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
	David S. Miller

We already unlocked a few lines earlier here, so we can go directly to
drop without passing through unlock.  This was introduced recently in
c5d3687f6c ('6lowpan: read data from skb safely').

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
index ad0c226..cd5007f 100644
--- a/net/ieee802154/6lowpan.c
+++ b/net/ieee802154/6lowpan.c
@@ -771,7 +771,7 @@ lowpan_process_data(struct sk_buff *skb)
 			kfree(frame);
 
 			if (lowpan_fetch_skb_u8(skb, &iphc0))
-				goto unlock_and_drop;
+				goto drop;
 
 			break;
 		}

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-06-27  8:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-27  6:53 [patch -next] 6lowpan: double unlock on an error path Dan Carpenter
2012-06-27  6:53 ` Dan Carpenter
2012-06-27  6:57 ` Alexander Smirnov
2012-06-27  6:57   ` Alexander Smirnov
2012-06-27  8:17   ` David Miller
2012-06-27  8:17     ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.