Re: [PATCH v2] ASoC: tlv320aic3x: add missing registers and bits

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1773 bytes --]

On Wed, Jun 27, 2012 at 08:06:59AM +0200, Prchal Jiří wrote:
> Second version of patch keeping formatting.
> Adds missing register default values to cache.
> Adds register and bits definitions in header file.

> Changes are for TLV320AIC310x based on data sheet.

I tried to apply it but it doesn't apply, git am says:

error: home/prchal/arm/fw-cdu/linux/linux-3.5-rc3/sound/soc/codecs/tlv320aic3x.c.new: does not exist in index

which is because:

> --- /home/prchal/arm/fw-cdu/linux/linux-3.5-rc3/sound/soc/codecs/tlv320aic3x.c.orig
> +++ /home/prchal/arm/fw-cdu/linux/linux-3.5-rc3/sound/soc/codecs/tlv320aic3x.c.new

Please format the patch as covered in SubmittingPatches, it should be
something that can be applied patch -p1.  Also...

> @@ -122,7 +122,9 @@
>  	0x00, 0x00, 0x00, 0x00,	/* 88 */
>  	0x00, 0x00, 0x00, 0x00,	/* 92 */
>  	0x00, 0x00, 0x00, 0x00,	/* 96 */
> -	0x00, 0x00, 0x02,	/* 100 */
> +	0x00, 0x00, 0x02, 0x00,	/* 100 */
> +	0x00, 0x00, 0x00, 0x00,	/* 104 */
> +	0x00, 0x00,             /* 108 */
>  };

This is a lot clearer, your changelog (and the previous submission)
suggested that there may be some errors in the register default values
since you were talking about missing bits but really all you're doing is
adding new registers which is a bit different to correcting mistakes.

The "missing bits" here are instead just:

> @@ -74,6 +74,8 @@
>  #define HPLCOM_CFG			37
>  /* Right High Power Output control registers */
>  #define HPRCOM_CFG			38
> +/* High Power Output Stage Control Register */
> +#define HPOUT_SC			40
>  /* DAC Output Switching control registers */
>  #define DAC_LINE_MUX			41
>  /* High Power Output Driver Pop Reduction registers */

these new defines in the header.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]