All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Hiremath, Vaibhav" <hvaibhav@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: OMAP2+: cpu: Make cpu_class_is_omap2 true for all non-omap1 platforms
Date: Wed, 27 Jun 2012 09:17:45 -0700	[thread overview]
Message-ID: <20120627161745.GO3483@atomide.com> (raw)
In-Reply-To: <20120627133950.GJ3483@atomide.com>

* Tony Lindgren <tony@atomide.com> [120627 06:44]:
> * Hiremath, Vaibhav <hvaibhav@ti.com> [120614 07:37]:
> > On Mon, Jun 11, 2012 at 18:52:54, Hiremath, Vaibhav wrote:
> > > As omap1 and omap2 will never be compiled together, due to
> > > different compiler flags, so we can simply make
> > > cpu_class_is_omap2() = true, for all non-omap1 platforms.
> > > 
> > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > > ---
> > >  arch/arm/plat-omap/include/plat/cpu.h |    3 +--
> > >  1 files changed, 1 insertions(+), 2 deletions(-)
> > > 
> > 
> > Tony,
> > 
> > Ping???
> 
> Thanks applying into devel-am33xx branch.

Actually looks like this fails for the dynamic detection
case with omap1_defconfig.. Looks like you did not build
test your patch with omap1_defconfig? Please do it for
every patch!

It seems we need something better though for multi zImage
too, we can't really rely on CONFIG_ARCH_OMAP1 or
CONFIG_ARCH_OMAP2PLUS here to determine anything.

Anyways, dropping this for now, let's try to come up
with something better.

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: cpu: Make cpu_class_is_omap2 true for all non-omap1 platforms
Date: Wed, 27 Jun 2012 09:17:45 -0700	[thread overview]
Message-ID: <20120627161745.GO3483@atomide.com> (raw)
In-Reply-To: <20120627133950.GJ3483@atomide.com>

* Tony Lindgren <tony@atomide.com> [120627 06:44]:
> * Hiremath, Vaibhav <hvaibhav@ti.com> [120614 07:37]:
> > On Mon, Jun 11, 2012 at 18:52:54, Hiremath, Vaibhav wrote:
> > > As omap1 and omap2 will never be compiled together, due to
> > > different compiler flags, so we can simply make
> > > cpu_class_is_omap2() = true, for all non-omap1 platforms.
> > > 
> > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > > ---
> > >  arch/arm/plat-omap/include/plat/cpu.h |    3 +--
> > >  1 files changed, 1 insertions(+), 2 deletions(-)
> > > 
> > 
> > Tony,
> > 
> > Ping???
> 
> Thanks applying into devel-am33xx branch.

Actually looks like this fails for the dynamic detection
case with omap1_defconfig.. Looks like you did not build
test your patch with omap1_defconfig? Please do it for
every patch!

It seems we need something better though for multi zImage
too, we can't really rely on CONFIG_ARCH_OMAP1 or
CONFIG_ARCH_OMAP2PLUS here to determine anything.

Anyways, dropping this for now, let's try to come up
with something better.

Tony

  parent reply	other threads:[~2012-06-27 16:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-11 13:22 [PATCH] ARM: OMAP2+: cpu: Make cpu_class_is_omap2 true for all non-omap1 platforms Vaibhav Hiremath
2012-06-11 13:22 ` Vaibhav Hiremath
2012-06-14 14:33 ` Hiremath, Vaibhav
2012-06-14 14:33   ` Hiremath, Vaibhav
2012-06-27 13:39   ` Tony Lindgren
2012-06-27 13:39     ` Tony Lindgren
2012-06-27 13:50     ` Hiremath, Vaibhav
2012-06-27 13:50       ` Hiremath, Vaibhav
2012-06-27 13:58       ` Tony Lindgren
2012-06-27 13:58         ` Tony Lindgren
2012-06-27 15:27         ` Hiremath, Vaibhav
2012-06-27 15:27           ` Hiremath, Vaibhav
2012-06-27 16:17     ` Tony Lindgren [this message]
2012-06-27 16:17       ` Tony Lindgren
2012-06-27 20:33       ` Hiremath, Vaibhav
2012-06-27 20:33         ` Hiremath, Vaibhav
2012-07-10  8:41         ` Tony Lindgren
2012-07-10  8:41           ` Tony Lindgren
2012-07-10  9:10           ` Hiremath, Vaibhav
2012-07-10  9:10             ` Hiremath, Vaibhav
2012-07-10  9:18             ` Tony Lindgren
2012-07-10  9:18               ` Tony Lindgren
2012-07-10  9:25               ` Hiremath, Vaibhav
2012-07-10  9:25                 ` Hiremath, Vaibhav
2012-07-10  9:43                 ` Tony Lindgren
2012-07-10  9:43                   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120627161745.GO3483@atomide.com \
    --to=tony@atomide.com \
    --cc=hvaibhav@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.