From: Tejun Heo <tj@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Michal Hocko <mhocko@suse.cz>, Zhouping Liu <zliu@redhat.com>,
linux-mm@kvack.org, Li Zefan <lizefan@huawei.com>,
CAI Qian <caiqian@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: memcg: cat: memory.memsw.* : Operation not supported
Date: Wed, 27 Jun 2012 13:09:26 -0700 [thread overview]
Message-ID: <20120627200926.GR15811@google.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1206271256120.22162@chino.kir.corp.google.com>
Hello, Michal, David.
On Wed, Jun 27, 2012 at 01:04:51PM -0700, David Rientjes wrote:
> I think it's a crappy solution and one that is undocumented in
> Documentation/cgroups/memory.txt. If you can only enable swap accounting
> at boot either via .config or the command line then these files should
> never be added for CONFIG_CGROUP_MEM_RES_CTLR_SWAP=n or when
> do_swap_account is 0. It's much easier to test if the feature is enabled
> by checking for the presence of these files at the memcg mount point
> rather than doing an open(2) and checking for -EOPNOTSUPP, which isn't
> even a listed error code. I don't care how much cleaner it makes the
> internal memcg code.
Yeah, it's kinda ugly. Taking a step back, do we really need be able
to configure out memsw? How much vmlinux bloat or runtime overhead
are we talking about? I don't think config options need to be this
granular.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Michal Hocko <mhocko@suse.cz>, Zhouping Liu <zliu@redhat.com>,
linux-mm@kvack.org, Li Zefan <lizefan@huawei.com>,
CAI Qian <caiqian@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: memcg: cat: memory.memsw.* : Operation not supported
Date: Wed, 27 Jun 2012 13:09:26 -0700 [thread overview]
Message-ID: <20120627200926.GR15811@google.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1206271256120.22162@chino.kir.corp.google.com>
Hello, Michal, David.
On Wed, Jun 27, 2012 at 01:04:51PM -0700, David Rientjes wrote:
> I think it's a crappy solution and one that is undocumented in
> Documentation/cgroups/memory.txt. If you can only enable swap accounting
> at boot either via .config or the command line then these files should
> never be added for CONFIG_CGROUP_MEM_RES_CTLR_SWAP=n or when
> do_swap_account is 0. It's much easier to test if the feature is enabled
> by checking for the presence of these files at the memcg mount point
> rather than doing an open(2) and checking for -EOPNOTSUPP, which isn't
> even a listed error code. I don't care how much cleaner it makes the
> internal memcg code.
Yeah, it's kinda ugly. Taking a step back, do we really need be able
to configure out memsw? How much vmlinux bloat or runtime overhead
are we talking about? I don't think config options need to be this
granular.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-06-27 20:09 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2a1a74bf-fbb5-4a6e-b958-44fff8debff2@zmail13.collab.prod.int.phx2.redhat.com>
2012-06-27 3:49 ` memcg: cat: memory.memsw.* : Operation not supported Zhouping Liu
2012-06-27 3:49 ` Zhouping Liu
2012-06-27 15:48 ` Michal Hocko
2012-06-27 15:48 ` Michal Hocko
2012-06-27 20:04 ` David Rientjes
2012-06-27 20:04 ` David Rientjes
2012-06-27 20:09 ` Tejun Heo [this message]
2012-06-27 20:09 ` Tejun Heo
2012-06-27 20:21 ` David Rientjes
2012-06-27 20:21 ` David Rientjes
2012-06-27 20:24 ` Tejun Heo
2012-06-27 20:24 ` Tejun Heo
2012-06-27 20:26 ` David Rientjes
2012-06-27 20:26 ` David Rientjes
2012-06-28 4:04 ` Kamezawa Hiroyuki
2012-06-28 4:04 ` Kamezawa Hiroyuki
2012-06-28 18:31 ` Tejun Heo
2012-06-28 18:31 ` Tejun Heo
2012-06-30 3:45 ` Kamezawa Hiroyuki
2012-06-30 3:45 ` Kamezawa Hiroyuki
2013-01-21 8:39 ` Zhouping Liu
2013-01-21 8:39 ` Zhouping Liu
2013-01-21 10:56 ` Michal Hocko
2013-01-21 10:56 ` Michal Hocko
2013-01-21 11:12 ` Michal Hocko
2013-01-21 11:12 ` Michal Hocko
2013-01-21 13:27 ` Zhouping Liu
2013-01-21 13:27 ` Zhouping Liu
2013-01-21 13:46 ` Michal Hocko
2013-01-21 13:46 ` Michal Hocko
2012-06-29 7:16 ` Glauber Costa
2012-06-29 7:16 ` Glauber Costa
2012-06-28 12:36 ` Michal Hocko
2012-06-28 12:36 ` Michal Hocko
2012-06-28 18:29 ` Tejun Heo
2012-06-28 18:29 ` Tejun Heo
2012-06-29 0:11 ` Kamezawa Hiroyuki
2012-06-29 0:11 ` Kamezawa Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627200926.GR15811@google.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=caiqian@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=zliu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.