From: Eduardo Valentin <eduardo.valentin@ti.com>
To: "R, Durgadoss" <durgadoss.r@intel.com>
Cc: Konstantin Baydarov <kbaidarov@dev.rtsoft.ru>,
"amit.kucheria@linaro.org" <amit.kucheria@linaro.org>,
"kishon@ti.com" <kishon@ti.com>, "balbi@ti.com" <balbi@ti.com>,
"linux-pm@lists.linux-foundation.org"
<linux-pm@lists.linux-foundation.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 6/7] omap4: thermal: add basic CPU thermal zone
Date: Thu, 28 Jun 2012 08:24:00 +0300 [thread overview]
Message-ID: <20120628052400.GG2471@besouro> (raw)
In-Reply-To: <4D68720C2E767A4AA6A8796D42C8EB59149DB0@BGSMSX101.gar.corp.intel.com>
Hello Durga,
On Thu, Jun 28, 2012 at 05:16:43AM +0000, R, Durgadoss wrote:
> Hi,
>
> > > +
> > > + data = devm_kzalloc(bg_ptr->dev, sizeof(*data), GFP_KERNEL);
> > > + if (!data) {
> > > + dev_err(bg_ptr->dev, "kzalloc fail\n");
> > > + return -ENOMEM;
> > > + }
> > > + data->sensor_id = id;
> > > + data->bg_ptr = bg_ptr;
> > > + data->omap4_thermal = thermal_zone_device_register(domain, 0,
> > > + data, &omap4_thermal_ops, 0, 0, 0, 0);
>
> Please watch out for changes on this API.
> The third argument is the flag for writeable trip points.
> This patch is in linux-next. So, kindly have a look at this API
> implementation in thermal_sys.c in linux-next, when you submit this patch
> next time.
Ok. Thanks for the heads up. I will have a look on linux-next.
>
> Thanks,
> Durga
WARNING: multiple messages have this Message-ID (diff)
From: eduardo.valentin@ti.com (Eduardo Valentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-pm] [PATCH v3 6/7] omap4: thermal: add basic CPU thermal zone
Date: Thu, 28 Jun 2012 08:24:00 +0300 [thread overview]
Message-ID: <20120628052400.GG2471@besouro> (raw)
In-Reply-To: <4D68720C2E767A4AA6A8796D42C8EB59149DB0@BGSMSX101.gar.corp.intel.com>
Hello Durga,
On Thu, Jun 28, 2012 at 05:16:43AM +0000, R, Durgadoss wrote:
> Hi,
>
> > > +
> > > + data = devm_kzalloc(bg_ptr->dev, sizeof(*data), GFP_KERNEL);
> > > + if (!data) {
> > > + dev_err(bg_ptr->dev, "kzalloc fail\n");
> > > + return -ENOMEM;
> > > + }
> > > + data->sensor_id = id;
> > > + data->bg_ptr = bg_ptr;
> > > + data->omap4_thermal = thermal_zone_device_register(domain, 0,
> > > + data, &omap4_thermal_ops, 0, 0, 0, 0);
>
> Please watch out for changes on this API.
> The third argument is the flag for writeable trip points.
> This patch is in linux-next. So, kindly have a look at this API
> implementation in thermal_sys.c in linux-next, when you submit this patch
> next time.
Ok. Thanks for the heads up. I will have a look on linux-next.
>
> Thanks,
> Durga
next prev parent reply other threads:[~2012-06-28 5:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 18:05 [PATCH v3 6/7] omap4: thermal: add basic CPU thermal zone Konstantin Baydarov
2012-06-27 18:05 ` Konstantin Baydarov
2012-06-28 5:12 ` Eduardo Valentin
2012-06-28 5:12 ` Eduardo Valentin
2012-06-28 5:16 ` R, Durgadoss
2012-06-28 5:16 ` [linux-pm] " R, Durgadoss
2012-06-28 5:24 ` Eduardo Valentin [this message]
2012-06-28 5:24 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120628052400.GG2471@besouro \
--to=eduardo.valentin@ti.com \
--cc=amit.kucheria@linaro.org \
--cc=balbi@ti.com \
--cc=durgadoss.r@intel.com \
--cc=kbaidarov@dev.rtsoft.ru \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.