* [Cluster-devel] [PATCH 5/5] rgmanager: Fix a possible NULL pointer dereference
@ 2012-06-28 19:58 Ryan McCabe
2012-07-04 11:07 ` Fabio M. Di Nitto
0 siblings, 1 reply; 2+ messages in thread
From: Ryan McCabe @ 2012-06-28 19:58 UTC (permalink / raw)
To: cluster-devel.redhat.com
Fix a NULL pointer dereference that could happen when cman_get_node_count()
returns 0 with errno set to EINTR.
Possibly resolves rhbz#820632
Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
---
rgmanager/src/clulib/members.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/rgmanager/src/clulib/members.c b/rgmanager/src/clulib/members.c
index f705297..72f4529 100644
--- a/rgmanager/src/clulib/members.c
+++ b/rgmanager/src/clulib/members.c
@@ -367,8 +367,10 @@ get_member_list(cman_handle_t h)
do {
++tries;
- if (nodes)
+ if (nodes) {
free(nodes);
+ nodes = NULL;
+ }
c = cman_get_node_count(h);
if (c <= 0) {
--
1.7.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] [PATCH 5/5] rgmanager: Fix a possible NULL pointer dereference
2012-06-28 19:58 [Cluster-devel] [PATCH 5/5] rgmanager: Fix a possible NULL pointer dereference Ryan McCabe
@ 2012-07-04 11:07 ` Fabio M. Di Nitto
0 siblings, 0 replies; 2+ messages in thread
From: Fabio M. Di Nitto @ 2012-07-04 11:07 UTC (permalink / raw)
To: cluster-devel.redhat.com
ACK
On 6/28/2012 9:58 PM, Ryan McCabe wrote:
> Fix a NULL pointer dereference that could happen when cman_get_node_count()
> returns 0 with errno set to EINTR.
>
> Possibly resolves rhbz#820632
>
> Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
> ---
> rgmanager/src/clulib/members.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/rgmanager/src/clulib/members.c b/rgmanager/src/clulib/members.c
> index f705297..72f4529 100644
> --- a/rgmanager/src/clulib/members.c
> +++ b/rgmanager/src/clulib/members.c
> @@ -367,8 +367,10 @@ get_member_list(cman_handle_t h)
>
> do {
> ++tries;
> - if (nodes)
> + if (nodes) {
> free(nodes);
> + nodes = NULL;
> + }
>
> c = cman_get_node_count(h);
> if (c <= 0) {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-04 11:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-28 19:58 [Cluster-devel] [PATCH 5/5] rgmanager: Fix a possible NULL pointer dereference Ryan McCabe
2012-07-04 11:07 ` Fabio M. Di Nitto
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.