All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@ti.com>
Cc: Jean Pihet <jean.pihet@newoldbits.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Jean Pihet <j-pihet@ti.com>
Subject: Re: [PATCH] ARM: OMAP2+: do not allow SmartReflex to be built as a module
Date: Fri, 29 Jun 2012 06:05:28 -0700	[thread overview]
Message-ID: <20120629130527.GG4202@atomide.com> (raw)
In-Reply-To: <1340902538-1318-1-git-send-email-khilman@ti.com>

* Kevin Hilman <khilman@ti.com> [120628 10:00]:
> From: Jean Pihet <j-pihet@ti.com>
> 
> Disable the module option for POWER_AVS since this is currently not
> supported.
> 
> This patch fixes these error in the case POWER_AVS is set to 'm':
> 
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_configure':
> /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:43: undefined reference to `sr_configure_errgen'
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_disable':
> /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:33: undefined reference to `sr_disable_errgen'
> /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:35: undefined reference to `sr_disable'
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_enable':
> /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:28: undefined reference to `sr_enable'
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_init':
> /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:59: undefined reference to `sr_register_class'
> 
> Reported-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Jean Pihet <j-pihet@ti.com>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> ---
> Tony, this one fixes the SR related build errors you saw with
> randconfig.  It applies to my for_3.6/pm/sr-move branch which is now
> included in your devel-driver.  Let me know if want me to fold this
> into the original and re-spin the branch.
> 
> Also, special thanks to Jean for fixing this immediatly after it 
> was reported!

Thanks applying into devel-driver branch.

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: do not allow SmartReflex to be built as a module
Date: Fri, 29 Jun 2012 06:05:28 -0700	[thread overview]
Message-ID: <20120629130527.GG4202@atomide.com> (raw)
In-Reply-To: <1340902538-1318-1-git-send-email-khilman@ti.com>

* Kevin Hilman <khilman@ti.com> [120628 10:00]:
> From: Jean Pihet <j-pihet@ti.com>
> 
> Disable the module option for POWER_AVS since this is currently not
> supported.
> 
> This patch fixes these error in the case POWER_AVS is set to 'm':
> 
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_configure':
> /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:43: undefined reference to `sr_configure_errgen'
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_disable':
> /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:33: undefined reference to `sr_disable_errgen'
> /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:35: undefined reference to `sr_disable'
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_enable':
> /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:28: undefined reference to `sr_enable'
> arch/arm/mach-omap2/built-in.o: In function `sr_class3_init':
> /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:59: undefined reference to `sr_register_class'
> 
> Reported-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Jean Pihet <j-pihet@ti.com>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
> ---
> Tony, this one fixes the SR related build errors you saw with
> randconfig.  It applies to my for_3.6/pm/sr-move branch which is now
> included in your devel-driver.  Let me know if want me to fold this
> into the original and re-spin the branch.
> 
> Also, special thanks to Jean for fixing this immediatly after it 
> was reported!

Thanks applying into devel-driver branch.

Tony

  reply	other threads:[~2012-06-29 13:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 16:55 [PATCH] ARM: OMAP2+: do not allow SmartReflex to be built as a module Kevin Hilman
2012-06-28 16:55 ` Kevin Hilman
2012-06-29 13:05 ` Tony Lindgren [this message]
2012-06-29 13:05   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120629130527.GG4202@atomide.com \
    --to=tony@atomide.com \
    --cc=j-pihet@ti.com \
    --cc=jean.pihet@newoldbits.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.