From: Johannes Weiner <hannes@cmpxchg.org>
To: Petr Holasek <pholasek@redhat.com>
Cc: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Chris Wright <chrisw@sous-sol.org>,
Izik Eidus <izik.eidus@ravellosystems.com>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Anton Arapov <anton@redhat.com>
Subject: Re: [PATCH v2] KSM: numa awareness sysfs knob
Date: Fri, 29 Jun 2012 18:47:06 +0200 [thread overview]
Message-ID: <20120629164706.GA7831@cmpxchg.org> (raw)
In-Reply-To: <20120629163033.GA11327@stainedmachine.redhat.com>
On Fri, Jun 29, 2012 at 06:30:33PM +0200, Petr Holasek wrote:
> On Fri, 29 Jun 2012, Johannes Weiner wrote:
> > On Fri, Jun 29, 2012 at 01:49:52PM +0200, Petr Holasek wrote:
> > > Introduces new sysfs boolean knob /sys/kernel/mm/ksm/merge_nodes
> > > which control merging pages across different numa nodes.
> > > When it is set to zero only pages from the same node are merged,
> > > otherwise pages from all nodes can be merged together (default behavior).
> >
> > Is it conceivable that admins may (in the future) want to merge only
> > across nodes that are below a given distance threshold?
> >
> > I'm not asking to implement this, just whether the knob can be
> > introduced such that it's future-compatible. Make it default to a
> > Very High Number and only allow setting it to 0 for now e.g.? And
> > name it max_node_merge_distance (I'm bad at names)?
> >
> > What do you think?
>
> I started with exactly same idea as you described above in the first
> RFC, link: https://lkml.org/lkml/2011/11/30/91
> But this approach turned out to be more complicated than it looked
> (see two last emails in thread) and complexity of solution would rise
> a lot.
Oh, I should have checked the archives given that it's v2. I expected
it to get complex but didn't put enough thought into it to see /that/
amount of complexity. Sorry.
Carry on, then :-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Petr Holasek <pholasek@redhat.com>
Cc: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Chris Wright <chrisw@sous-sol.org>,
Izik Eidus <izik.eidus@ravellosystems.com>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Anton Arapov <anton@redhat.com>
Subject: Re: [PATCH v2] KSM: numa awareness sysfs knob
Date: Fri, 29 Jun 2012 18:47:06 +0200 [thread overview]
Message-ID: <20120629164706.GA7831@cmpxchg.org> (raw)
In-Reply-To: <20120629163033.GA11327@stainedmachine.redhat.com>
On Fri, Jun 29, 2012 at 06:30:33PM +0200, Petr Holasek wrote:
> On Fri, 29 Jun 2012, Johannes Weiner wrote:
> > On Fri, Jun 29, 2012 at 01:49:52PM +0200, Petr Holasek wrote:
> > > Introduces new sysfs boolean knob /sys/kernel/mm/ksm/merge_nodes
> > > which control merging pages across different numa nodes.
> > > When it is set to zero only pages from the same node are merged,
> > > otherwise pages from all nodes can be merged together (default behavior).
> >
> > Is it conceivable that admins may (in the future) want to merge only
> > across nodes that are below a given distance threshold?
> >
> > I'm not asking to implement this, just whether the knob can be
> > introduced such that it's future-compatible. Make it default to a
> > Very High Number and only allow setting it to 0 for now e.g.? And
> > name it max_node_merge_distance (I'm bad at names)?
> >
> > What do you think?
>
> I started with exactly same idea as you described above in the first
> RFC, link: https://lkml.org/lkml/2011/11/30/91
> But this approach turned out to be more complicated than it looked
> (see two last emails in thread) and complexity of solution would rise
> a lot.
Oh, I should have checked the archives given that it's v2. I expected
it to get complex but didn't put enough thought into it to see /that/
amount of complexity. Sorry.
Carry on, then :-)
next prev parent reply other threads:[~2012-06-29 16:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 11:49 [PATCH v2] KSM: numa awareness sysfs knob Petr Holasek
2012-06-29 11:49 ` Petr Holasek
2012-06-29 13:03 ` Cong Wang
2012-06-29 13:23 ` Petr Holasek
2012-06-29 13:23 ` Petr Holasek
2012-06-29 16:05 ` Johannes Weiner
2012-06-29 16:05 ` Johannes Weiner
2012-06-29 16:30 ` Petr Holasek
2012-06-29 16:30 ` Petr Holasek
2012-06-29 16:47 ` Johannes Weiner [this message]
2012-06-29 16:47 ` Johannes Weiner
2012-06-29 22:30 ` David Rientjes
2012-06-29 22:30 ` David Rientjes
2012-06-30 11:40 ` Petr Holasek
2012-06-30 11:40 ` Petr Holasek
2012-07-02 21:26 ` David Rientjes
2012-07-02 21:26 ` David Rientjes
2012-07-03 17:02 ` Petr Holasek
2012-07-03 17:02 ` Petr Holasek
2012-06-29 21:17 ` Andrew Morton
2012-06-29 21:17 ` Andrew Morton
2012-06-29 22:50 ` David Rientjes
2012-06-29 22:50 ` David Rientjes
2012-06-30 9:43 ` Izik Eidus
2012-06-30 9:43 ` Izik Eidus
2012-06-30 12:29 ` Petr Holasek
2012-06-30 12:29 ` Petr Holasek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120629164706.GA7831@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anton@redhat.com \
--cc=chrisw@sous-sol.org \
--cc=hughd@google.com \
--cc=izik.eidus@ravellosystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pholasek@redhat.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.