From: Minchan Kim <minchan@kernel.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vmscan: remove obsolete comment of shrinker
Date: Sat, 30 Jun 2012 07:32:35 +0900 [thread overview]
Message-ID: <20120629223235.GB2079@barrios> (raw)
In-Reply-To: <jsk9pt$32e$2@dough.gmane.org>
On Fri, Jun 29, 2012 at 01:15:43PM +0000, Cong Wang wrote:
>
> On Fri, 29 Jun 2012 at 04:51 GMT, Minchan Kim <minchan@kernel.org> wrote:
> > 09f363c7 fixed shrinker callback returns -1 when nr_to_scan is zero
> > for preventing excessive the slab scanning. But 635697c6 fixed the
> > problem, again so we can freely return -1 although nr_to_scan is zero.
> > So let's revert 09f363c7 because the comment added in 09f363c7 made a
> > unnecessary rule shrinker user should be aware of.
> >
>
> Please also include the subject of the commit, not just raw hash number. ;)
>
> For example,
>
> 09f363c7("vmscan: fix shrinker callback bug in fs/super.c")
> 635697c6("vmscan: fix initial shrinker size handling")
Yeb. It seems akpm handled it by himself.
But I will keep in mind.
Thanks, Cong!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vmscan: remove obsolete comment of shrinker
Date: Sat, 30 Jun 2012 07:32:35 +0900 [thread overview]
Message-ID: <20120629223235.GB2079@barrios> (raw)
In-Reply-To: <jsk9pt$32e$2@dough.gmane.org>
On Fri, Jun 29, 2012 at 01:15:43PM +0000, Cong Wang wrote:
>
> On Fri, 29 Jun 2012 at 04:51 GMT, Minchan Kim <minchan@kernel.org> wrote:
> > 09f363c7 fixed shrinker callback returns -1 when nr_to_scan is zero
> > for preventing excessive the slab scanning. But 635697c6 fixed the
> > problem, again so we can freely return -1 although nr_to_scan is zero.
> > So let's revert 09f363c7 because the comment added in 09f363c7 made a
> > unnecessary rule shrinker user should be aware of.
> >
>
> Please also include the subject of the commit, not just raw hash number. ;)
>
> For example,
>
> 09f363c7("vmscan: fix shrinker callback bug in fs/super.c")
> 635697c6("vmscan: fix initial shrinker size handling")
Yeb. It seems akpm handled it by himself.
But I will keep in mind.
Thanks, Cong!
next prev parent reply other threads:[~2012-06-29 22:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 4:51 [PATCH] vmscan: remove obsolete comment of shrinker Minchan Kim
2012-06-29 4:51 ` Minchan Kim
2012-06-29 13:15 ` Cong Wang
2012-06-29 22:32 ` Minchan Kim [this message]
2012-06-29 22:32 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120629223235.GB2079@barrios \
--to=minchan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.